Changeset 2621 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-screenshots.php

Timestamp:

02/25/2016 10:49:24 PM (9 years ago)

Author:

obenland

Message:

Plugins Directory: Formatting update.

• Updates phpdocs throughout the plugin.
• Breaks out classes into their own files.
• Some minor namespace-related tweaks.

See #1584.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-screenshots.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-screenshots.php

@@ -1 +1 @@
 <?php
 namespace WordPressdotorg\Plugin_Directory\Shortcodes;
+
 use WordPressdotorg\Plugin_Directory\Template;
 
@@ -6 +7 @@
  * The [wporg-plugins-screenshots] shortcode handler to display a plugins screenshots.
  *
- * @package WordPressdotorg_Plugin_Directory
+ * @package WordPressdotorg\Plugin_Directory\Shortcodes
  */
 class Screenshots {
+
+    /**
+     * @return string
+     */
     static function display() {
         $plugin = get_post();
+        $output = '';
 
-        // All indexed from 1
+        // All indexed from 1.
         $screenshot_descriptions = get_post_meta( $plugin->ID, 'screenshots', true );
-        $assets_screenshots = get_post_meta( $plugin->ID, 'assets_screenshots', true );
+        $assets_screenshots      = get_post_meta( $plugin->ID, 'assets_screenshots', true );
 
-        $output = '';
         foreach ( $screenshot_descriptions as $index => $description ) {
-            // Find the image that corresponds with the text.
-            // The image numbers are stored within the 'resolution' key.
-            $found = false;
+
+            /*
+             * Find the image that corresponds with the text.
+             * The image numbers are stored within the 'resolution' key.
+             */
             foreach ( $assets_screenshots as $image ) {
                 if ( $index == $image['resolution'] ) {
-                    $found = true;
+                    $output .= sprintf(
+                        '<li>
+                            <a href="%1$s" rel="nofollow">
+                                <img class="screenshot" src="%1$s">
+                            </a>
+                            <p>%2$s</p>
+                        </li>',
+                        Template::get_asset_url( $plugin->post_name, $image ),
+                        $description
+                    );
                     break;
                 }
             }
-            if ( ! $found ) {
-                continue;
-            }
-
-            $url = Template::get_asset_url( $plugin->post_name, $image );
-
-            $output .= sprintf(
-                '<li>
-                    <a href="%1$s" rel="nofollow">
-                        <img class="screenshot" src="%1$s">
-                    </a>
-                    <p>%2$s</p>
-                </li>',
-                $url,
-                $description
-            );
         }
 
         return '<ol class="screenshots">' . $output . '</ol>';
-
     }
 }