Changeset 2626

Timestamp:

02/26/2016 12:30:19 AM (9 years ago)

Author:

kovshenin

Message:

WordCamp.org: In payment requests, log and timestamp update on save_post, regardless of lack of form submit.

File:

• sites/branches/wcb-payment-request-statuses/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php (modified) (2 diffs)

sites/branches/wcb-payment-request-statuses/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/payment-request.php

@@ -700 +700 @@
      */
     public function save_payment( $post_id, $post ) {
+
+        // Update the timestamp and logs either way.
+        if ( $post->post_type == self::POST_TYPE && $post_id ) {
+            update_post_meta( $post_id, '_wcb_updated_timestamp', time() );
+
+            $user = get_user_by( 'id', get_current_user_id() );
+
+            // Look at post status transitions.
+            foreach ( self::$transition_post_status as $data ) {
+                list( $new, $old, $transition_post ) = $data;
+
+                // Transitioning a different post.
+                if ( $transition_post->ID != $post->ID )
+                    continue;
+
+                if ( $new == 'incomplete' || $new == 'wcb-incomplete' ) {
+                    $incomplete_text = get_post_meta( $post->ID, '_wcp_incomplete_notes', true );
+                    $incomplete_text = preg_replace( '#\.$#', '', $incomplete_text ); // trailing-undot-it.
+                    WordCamp_Budgets::log( $post->ID, $user->ID, sprintf( 'Marked as incomplete: %s', $incomplete_text ), array(
+                        'action' => 'marked-incomplete',
+                        'reason' => 'maybe notes',
+                    ) );
+
+                    $this->notify_requester_request_incomplete( $post->ID );
+                    WordCamp_Budgets::log( $post->ID, $user->ID, 'Incomplete notification e-mail sent.', array(
+                        'action' => 'incomplete-notification-sent',
+                    ) );
+
+                } elseif ( $new == 'paid' || $new == 'wcb-paid' ) {
+                    WordCamp_Budgets::log( $post->ID, $user->ID, 'Marked as paid', array(
+                        'action' => 'marked-paid',
+                    ) );
+
+                    $this->notify_requester_payment_made( $post->ID );
+                    WordCamp_Budgets::log( $post->ID, $user->ID, 'Paid notification e-mail sent.', array(
+                        'action' => 'paid-notification-sent',
+                    ) );
+
+                } elseif ( $old == 'auto-draft' ) {
+                    WordCamp_Budgets::log( $post->ID, $user->ID, 'Request created', array(
+                        'action' => 'updated',
+                    ) );
+                }
+            }
+
+            WordCamp_Budgets::log( $post->ID, $user->ID, 'Request updated', array(
+                'action' => 'updated',
+            ) );
+        }
+
+        // The rest only if triggered by a user submitting a form.
         if ( ! WordCamp_Budgets::post_edit_is_actionable( $post, self::POST_TYPE ) ) {
             return;
@@ -717 +768 @@
         WordCamp_Budgets::validate_save_payment_method_fields( $post_id, 'camppayments' );
         $this->sanitize_save_misc_fields( $post_id );
-
-        update_post_meta( $post_id, '_wcb_updated_timestamp', time() );
-        $user = get_user_by( 'id', get_current_user_id() );
-
-        // Look at post status transitions.
-        foreach ( self::$transition_post_status as $data ) {
-            list( $new, $old, $transition_post ) = $data;
-
-            // Transitioning a different post.
-            if ( $transition_post->ID != $post->ID )
-                continue;
-
-            if ( $new == 'incomplete' || $new == 'wcb-incomplete' ) {
-                $incomplete_text = get_post_meta( $post->ID, '_wcp_incomplete_notes', true );
-                $incomplete_text = preg_replace( '#\.$#', '', $incomplete_text ); // trailing-undot-it.
-                WordCamp_Budgets::log( $post->ID, $user->ID, sprintf( 'Marked as incomplete: %s', $incomplete_text ), array(
-                    'action' => 'marked-incomplete',
-                    'reason' => 'maybe notes',
-                ) );
-
-                $this->notify_requester_request_incomplete( $post->ID );
-                WordCamp_Budgets::log( $post->ID, $user->ID, 'Incomplete notification e-mail sent.', array(
-                    'action' => 'incomplete-notification-sent',
-                ) );
-
-            } elseif ( $new == 'paid' || $new == 'wcb-paid' ) {
-                WordCamp_Budgets::log( $post->ID, $user->ID, 'Marked as paid', array(
-                    'action' => 'marked-paid',
-                ) );
-
-                $this->notify_requester_payment_made( $post->ID );
-                WordCamp_Budgets::log( $post->ID, $user->ID, 'Paid notification e-mail sent.', array(
-                    'action' => 'paid-notification-sent',
-                ) );
-
-            } elseif ( $old == 'auto-draft' ) {
-                WordCamp_Budgets::log( $post->ID, $user->ID, 'Request created', array(
-                    'action' => 'updated',
-                ) );
-            }
-        }
-
-        WordCamp_Budgets::log( $post->ID, $user->ID, 'Request updated', array(
-            'action' => 'updated',
-        ) );
     }