Context Navigation

← Previous Change
Next Change →

wordcamp-participation-notifier.php

Timestamp:

03/11/2016 11:53:09 PM (10 years ago)

Author:

iandunn

Message:

WordCamp.org: Centralize user fetching functionality.

Previously wordcamp-participation-notifier and wc-post-types were using slightly different code to get the same data, which resulted in a bug where wc-post-types would find the user, but wordcamp-participation-notifier wouldn't. That led to some profile badges being removed when the speaker/organizer post was updated, because the notifier would think the username was removed from the field, and send a command to remove the badge.

Because the two plugins are interdependent, they need to use a common function to guarantee identical results.

get_saved_wporg_user_id() doesn't need to use the new function, because tix_username is always set from user_login, rather than being entered as user-input.

See #977

File:

: 1 edited

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php

r2742	r2743
311	311
312	312	if ( in_array( $post->post_type, array( 'wcb_speaker', 'wcb_organizer' ) ) && isset( $_POST['wcpt-wporg-username'] ) ) {
313		$user = ~~get_user_by( 'login',~~ $_POST['wcpt-wporg-username'] );
	313	$user = wcorg_get_user_by_canonical_names( $_POST['wcpt-wporg-username'] );
314	314	}
315	315

Note: See TracChangeset for help on using the changeset viewer.

Making WordPress.org

Context Navigation

Changeset 2743 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php

Legend:

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-participation-notifier/wordcamp-participation-notifier.php

Download in other formats: