Changeset 2744

Timestamp:

03/14/2016 01:58:14 PM (9 years ago)

Author:

ocean90

Message:

Translate, Rosetta Roles: In WPorg_GP_Rosetta_Roles::is_approver_for_locale() don't use in_array() to check whether a capability exists.

Capabilities are stored as [ $cap => bool ], which means in_array( 'translation_editor', array( 'contributor' => true ) ) returns alway true (if the strict parameter isn't set).

See #1352.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-rosetta-roles/wporg-gp-rosetta-roles.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-rosetta-roles/wporg-gp-rosetta-roles.php

@@ -179 +179 @@
         }
 
-        $is_approver = in_array( self::TRANSLATION_EDITOR_ROLE, $user->$cap_key ) || in_array( self::GENERAL_TRANSLATION_EDITOR_ROLE, $user->$cap_key );
+        $capabilities = $user->{$cap_key};
+        $is_approver = ! empty( $capabilities[ self::TRANSLATION_EDITOR_ROLE ] ) || ! empty( $capabilities[ self::GENERAL_TRANSLATION_EDITOR_ROLE ] );
         $cache[ $user_id ][ $locale_slug ] = $is_approver;