Changeset 2847

Timestamp:

03/29/2016 11:48:30 PM (11 years ago)

Author:

iandunn

Message:

WordCamp Post Type: Correct log entry status_change value.

The meta field key has an _ prefixed, but the type value in the processed array doesn't.

Prior to this change, the expression always evaluated to false, which made the sorting depend on whether $a was the note and $b was the status change, or vice-versa.

Location:

sites/branches/application-tracking/wordcamp.org/public_html/wp-content/plugins/wcpt

Files:

• applications/wordcamp.php (modified) (1 diff)
• wcpt-functions.php (modified) (1 diff)

sites/branches/application-tracking/wordcamp.org/public_html/wp-content/plugins/wcpt/applications/wordcamp.php

@@ -39 +39 @@
  * Render the output the of the [wordcamp-organizer-application] shortcode.
  *
+ * @todo Use force_login_to_view_form() and populate_form_based_on_user().
+ *
  * @return string
  */
 function render_application_shortcode() {
         ob_start();
-
-        // todo call force_login_to_view_form() and populate_form_based_on_user() ?
 
         if ( isset( $_POST['submit-application'] ) ) {

sites/branches/application-tracking/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-functions.php

@@ -136 +136 @@
         // If a status change and a note occur at the same time, show the change before the note
         if ( $a['timestamp'] == $b['timestamp'] ) {
-                return ( '_status_change' == $a['type'] ) ? -1 : 1; // todo not consistent
+                return ( 'status_change' == $a['type'] ) ? 1 : -1;
         }