Changeset 2916

Timestamp:

04/07/2016 07:07:58 PM (10 years ago)

Author:

ocean90

Message:

Trac: Don't try to add a commits box to non-ticket pages.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -388 +388 @@
 
             // List commits between #ticket and #attachments
-            var $commitChanges = $( 'div.change' ).has( '.comment > p > a.changeset' ).has( '.comment div.message p a.ticket' ),
-                $commits = $( '<ul/>' ), commitCount = 0;
-
-            $commitChanges.each( function( i, el ) {
-                var $el = $( el ), $comment = $el.find( '.comment' ), commitNumber, firstLine,
-                    author, date, $commit = $( '<li>' );
-
-                commitNumber = $comment.find( '> p ').html().trim().replace( /^In /, '' ).replace( /:<br>$/, '' );
-                $commit.append( '[' + commitNumber + '] ' );
-
-                firstLine = $comment.find( '.message > p' ).html().trim().replace( /<br>$/, '' );
-                $commit.append( firstLine + '&hellip;' );
-
-                author = $el.find( '.username' ).data( 'username' );
-                $commit.append( ' by <a href="https://profiles.wordpress.org/' + author + '">@' + author + '</a>' );
-
-                date = $el.find( '.time-ago' ).html();
-                $commit.append( ' ' + date );
-
-                $commits.append( $commit );
-                commitCount += 1;
-            });
-
-            $( '#ticket' ).after(
-                $( '<div/>', {
-                    id: 'commits',
-                    class: 'collapsed'
-                })
-                .append(
-                    $( '<h3/>', {
-                        class: 'foldable'
+            if ( $( '#content.ticket' ).length ) {
+                var $commitChanges = $( 'div.change' ).has( '.comment > p > a.changeset' ).has( '.comment div.message p a.ticket' ),
+                    $commits = $( '<ul/>' ), commitCount = 0;
+
+                $commitChanges.each( function( i, el ) {
+                    var $el = $( el ), $comment = $el.find( '.comment' ), commitNumber, firstLine,
+                        author, date, $commit = $( '<li>' );
+
+                    commitNumber = $comment.find( '> p ').html().trim().replace( /^In /, '' ).replace( /:<br>$/, '' );
+                    $commit.append( '[' + commitNumber + '] ' );
+
+                    firstLine = $comment.find( '.message > p' ).html().trim().replace( /<br>$/, '' );
+                    $commit.append( firstLine + '&hellip;' );
+
+                    author = $el.find( '.username' ).data( 'username' );
+                    $commit.append( ' by <a href="https://profiles.wordpress.org/' + author + '">@' + author + '</a>' );
+
+                    date = $el.find( '.time-ago' ).html();
+                    $commit.append( ' ' + date );
+
+                    $commits.append( $commit );
+                    commitCount += 1;
+                });
+
+                $( '#ticket' ).after(
+                    $( '<div/>', {
+                        id: 'commits',
+                        class: 'collapsed'
                     })
-                    .html( '<a href="#no0" id="no0">Commits <span class="trac-count">(' + commitCount + ')</span></a>' )
-                    .after(
-                        $( '<div/>', {
-                            class: 'commits'
+                    .append(
+                        $( '<h3/>', {
+                            class: 'foldable'
                         })
-                        .append( $commits )
+                        .html( '<a href="#no0" id="no0">Commits <span class="trac-count">(' + commitCount + ')</span></a>' )
+                        .after(
+                            $( '<div/>', {
+                                class: 'commits'
+                            })
+                            .append( $commits )
+                        )
                     )
-                )
-            );
+                );
+            }
 
             // See $.fn.enableFolding().