Changeset 2918 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-loader.php

Timestamp:

04/07/2016 08:54:17 PM (9 years ago)

Author:

iandunn

Message:

WordCamp Post Type: Only query the public post statuses on archives and feeds.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-loader.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-loader.php

@@ -25 +25 @@
         add_action( 'init',           array( $this, 'register_post_types'    ) );
         add_action( 'init',           array( $this, 'register_post_statuses' ) );
+        add_filter( 'pre_get_posts',  array( $this, 'query_public_statuses_on_archives' ) );
+
+        // todo re-align
     }
 
@@ -116 +119 @@
             ) );
         }
+    }
+
+    /**
+     * Only query the public post statuses on WordCamp archives and feeds
+     *
+     * By default, any public post statuses are queried when the `post_status` parameter is not explicitly passed
+     * to WP_Query. This causes central.wordcamp.org/wordcamps/ and central.wordcamp.org/wordcamps/feed/ to display
+     * camps that are `needs-vetting`, etc, which is not desired.
+     *
+     * Another way to fix this would have been to register some of the posts statuses as `private`, but they're not
+     * consistently used in a public or private way, so that would have had more side effects.
+     *
+     * @param WP_Query $query
+     */
+    public function query_public_statuses_on_archives( $query ) {
+        if ( ! $query->is_post_type_archive( WCPT_POST_TYPE_ID ) ) {
+            return;
+        }
+
+        if ( is_admin() ) {
+            return;
+        }
+
+        if ( ! empty( $query->query_vars['post_status'] ) ) {
+            return;
+        }
+
+        $query->query_vars['post_status'] = self::get_public_post_statuses();
     }