Changeset 2929 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

Timestamp:

04/11/2016 01:37:50 PM (4 years ago)

Author:

obenland

Message:

Plugin Directory: Allow committer mangament only for active plugins.

Plugins that are not yet live or are deprecated/hidden, should not have
committers added to them.

See #1570.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

@@ -26 +26 @@
     private function __construct() {
         // Admin Metaboxes
-        add_action( 'add_meta_boxes', array( $this, 'register_admin_metaboxes' ), 10, 1 );
+        add_action( 'add_meta_boxes', array( $this, 'register_admin_metaboxes' ), 10, 2 );
         add_action( 'do_meta_boxes', array( $this, 'replace_title_global' ) );
 
@@ -220 +220 @@
      * Register the Admin metaboxes for the plugin management screens.
      *
-     * @param string $post_type The post type of the current screen.
+     * @param string   $post_type The post type of the current screen.
+     * @param \WP_Post $post      Post object.
      * @return void.
      */
-    public function register_admin_metaboxes( $post_type ) {
+    public function register_admin_metaboxes( $post_type, $post ) {
         if ( 'plugin' != $post_type ) {
             return;
@@ -260 +261 @@
         );
 
-        add_meta_box(
-            'plugin-committers',
-            __( 'Plugin Committers', 'wporg-plugins' ),
-            array( __NAMESPACE__ . '\Metabox\Committers', 'display' ),
-            'plugin', 'side'
-        );
+        if ( 'publish' === $post->post_status ) {
+            add_meta_box(
+                'plugin-committers',
+                __( 'Plugin Committers', 'wporg-plugins' ),
+                array( __NAMESPACE__ . '\Metabox\Committers', 'display' ),
+                'plugin', 'side'
+            );
+        }
 
         // Remove unnecessary metaboxes.