Changeset 2949

Timestamp:

04/13/2016 05:02:55 PM (8 years ago)

Author:

ocean90

Message:

Translate, JS Warnings: Fix submitting new translations.

$gp.editor.hooks.ok() doesn't expect a parameter and uses $(this) instead. But the original this (the button) is lost during the custom callback.

See #1667.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-js-warnings/wporg-gp-js-warnings.js (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-js-warnings/wporg-gp-js-warnings.js

@@ -18 +18 @@
                 translation: $el.val(),
                 original: // Singular original, or plural original, or.. the single-original plural view..
-                    $el.parent('div.textareas').prev('p.original').text() || 
+                    $el.parent('div.textareas').prev('p.original').text() ||
                     $el.parent('div.textareas').prev('p').find('span.original').text() ||
-                    jQuery( $el.parents('div.strings').find('span.original').get(prop) ).text() 
+                    jQuery( $el.parents('div.strings').find('span.original').get(prop) ).text()
             }
         }).get();
@@ -51 +51 @@
 
         // No warnings, or warnings skipped
-        $gp.editor.hooks.ok( button );
+        $gp.editor.save( button );
+        return false;
     },
     check_entry: function( entry ) {