Changeset 298

Timestamp:

01/19/2014 07:19:54 PM (13 years ago)

Author:

nacin

Message:

Trac:

• After comment previews, re-hide CCs and re-show any image previews.
• Point new tickets in the 'WordPress.org site' component to meta.trac.

File:

• sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js (modified) (6 diffs)

sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js

@@ -31 +31 @@
         wpTrac = {
 
-                gardener : typeof wpBugGardener !== 'undefined',
-
-                init : function() {
+                gardener: typeof wpBugGardener !== 'undefined',
+
+                init: function() {
                         wpTrac.hacks();
                         if ( ! $(document.body).hasClass( 'plugins' ) ) {
@@ -41 +41 @@
                 },
 
-                hacks: function() {
-                        // Change 'Comments' and 'Stars' columns to dashicons glyphs to save space
-                        $('th a[href*="sort=Comments"]').html('<div class="dashicons dashicons-admin-comments"></div>');
-                        $('th a[href*="sort=Stars"]').html('<div class="dashicons dashicons-star-empty"></div>');
-
+                // These ticket hacks need to be re-run after ticket previews.
+                postPreviewHacks: function() {
                         // Automatically preview images.
                         $('li.trac-field-attachment').each( function() {
@@ -77 +74 @@
                                 el.children().appendTo( el.prev().children('.trac-ticket-buttons') ).end().end().remove();
                         });
+                },
+
+                hacks: function() {
+                        var content = $( '#content' );
+
+                        // Change 'Comments' and 'Stars' columns to dashicons glyphs to save space
+                        $('th a[href*="sort=Comments"]').html('<div class="dashicons dashicons-admin-comments"></div>');
+                        $('th a[href*="sort=Stars"]').html('<div class="dashicons dashicons-star-empty"></div>');
+
+                        if ( content.hasClass( 'ticket' ) ) {
+                                if ( $(document.body).hasClass( 'core' ) ) {
+                                        wpTrac.coreToMeta();
+                                }
+
+                                // A collection of ticket hacks that must be run again after previews.
+                                wpTrac.postPreviewHacks();
+                                content.on( 'wpTracPostPreview', wpTrac.postPreviewHacks );
+
+                                // Allow 'Modify Ticket' to be shown even after a Trac preview tries to close it,
+                                // but only if it was already open.
+                                (function(){
+                                        var action, hadClass,
+                                                form = $('#propertyform'),
+                                                modify = $('#modify').parent();
+
+                                        if ( ! form.length ) {
+                                                return;
+                                        }
+                                        action = form.attr('action');
+                                        $(document).ajaxSend( function( event, XMLHttpRequest, ajaxOptions ) {
+                                                if ( 0 !== action.indexOf( ajaxOptions.url ) ) {
+                                                        return;
+                                                }
+                                                hadClass = modify.hasClass('collapsed');
+                                        });
+                                        $(document).ajaxComplete( function( event, XMLHttpRequest, ajaxOptions ) {
+                                                if ( 0 !== action.indexOf( ajaxOptions.url ) ) {
+                                                        return;
+                                                }
+                                                if ( ! hadClass ) {
+                                                        modify.removeClass('collapsed');
+                                                }
+                                                content.triggerHandler( 'wpTracPostPreview' );
+                                        });
+                                })();
+                        }
 
                         // Add After the Deadline (only add it if it loaded)
@@ -92 +135 @@
                         // Push live comment previews above 'Modify Ticket'
                         $('#ticketchange').insertAfter('#trac-add-comment');
-
-                        // Allow 'Modify Ticket' to be shown even after a Trac preview tries to close it,
-                        // but only if it was already open.
-                        (function(){
-                                var action, hadClass,
-                                        form = $('#propertyform'),
-                                        modify = $('#modify').parent();
-
-                                if ( ! form.length ) {
-                                        return;
-                                }
-                                action = form.attr('action');
-                                $(document).ajaxSend( function( event, XMLHttpRequest, ajaxOptions ) {
-                                        if ( 0 !== action.indexOf( ajaxOptions.url ) ) {
-                                                return;
-                                        }
-                                        hadClass = modify.hasClass('collapsed');
-                                });
-                                $(document).ajaxComplete( function( event, XMLHttpRequest, ajaxOptions ) {
-                                        if ( hadClass || 0 !== action.indexOf( ajaxOptions.url ) ) {
-                                                return;
-                                        }
-                                        modify.removeClass('collapsed');
-                                });
-                        })();
 
                         // Toggle the security notice on component change, if rendered
@@ -224 +242 @@
                                 });
                         }
+                },
+
+                coreToMeta: function() {
+                        var component = $('#field-component');
+                        if ( window.location.pathname !== '/newticket' ) {
+                                if ( ! wpTrac.gardener && component.val() !== 'WordPress.org site' ) {
+                                        component.children('option[value="WordPress.org site"]').remove();
+                                }
+                                return;
+                        }
+
+                        component.change( function() {
+                                var toggle = $('input[name="attachment"]').parent().add('.ticketdraft').add('.wp-notice').add('div.buttons');
+                                if ( $(this).val() !== 'WordPress.org site' ) {
+                                        toggle.show();
+                                        $('.wp-notice.component').remove();
+                                        return;
+                                }
+                                toggle.hide();
+                                $('div.buttons').after( '<div class="wp-notice component"><p><strong>The WordPress.org site now has its own Trac</strong> at ' +
+                                        '<a href="//meta.trac.wordpress.org/">meta.trac.wordpress.org</a>.</p><p>Would you mind opening this ticket over there instead? ' +
+                                        '<a href="//meta.trac.wordpress.org/newticket" id="new-meta-ticket">Click here</a> to copy your summary and description over.</p></div>' );
+                        });
+        
+                        $('#propertyform').on( 'click', '#new-meta-ticket', function() {
+                                var url, href = $(this).attr( 'href' );
+                                url = href + '?' + $.param({ summary: $('#field-summary').val(), description: $('#field-description').val() });
+                                if ( url.length > 1500 ) {
+                                        url = href + '?' + $.param({
+                                                summary: $('#field-summary').val(),
+                                                description: "(Couldn't copy over your description as it was too long. Please paste it here. Your old window was not closed.)"
+                                        });
+                                        window.open( url );
+                                } else {
+                                        window.location.href = url;
+                                }
+                                return false;
+                        });
                 },
 
@@ -442 +498 @@
                                 }
                                 if ( content.hasClass( 'ticket' ) ) {
-                                        $( '#changelog div.change' ).has( 'li.trac-field-cc' ).each( function() {
-                                                var change = $(this), changes = change.children( 'ul.changes' );
-                                                /* Three possibilities:
-                                                   The comment is just a single CC (hide the whole comment)
-                                                   The comment is a CC plus a comment (hide the CC line)
-                                                   The comment contains multiple property changes (hide only the CC line)
-                                                */
-                                                if ( changes.children( 'li' ).length === 1 ) {
-                                                        if ( change.children( 'div.comment' ).length === 0 ) {
-                                                                change.hide();
-                                                        } else {
-                                                                changes.hide();
-                                                        }
+                                        hide_cc_comments();
+                                        content.on( 'wpTracPostPreview', hide_cc_comments );
+                                }
+                        }
+
+                        function hide_cc_comments() {
+                                $( '#changelog div.change' ).has( 'li.trac-field-cc' ).each( function() {
+                                        var change = $(this), changes = change.children( 'ul.changes' );
+                                        /* Three possibilities:
+                                           The comment is just a single CC (hide the whole comment)
+                                           The comment is a CC plus a comment (hide the CC line)
+                                           The comment contains multiple property changes (hide only the CC line)
+                                        */
+                                        if ( changes.children( 'li' ).length === 1 ) {
+                                                if ( change.children( 'div.comment' ).length === 0 ) {
+                                                        change.hide();
                                                 } else {
-                                                        changes.children( 'li.trac-field-cc' ).hide();
+                                                        changes.hide();
                                                 }
-                                        });
-                                }
+                                        } else {
+                                                changes.children( 'li.trac-field-cc' ).hide();
+                                        }
+                                });
                         }