Changeset 2981

Timestamp:

04/19/2016 08:05:57 PM (9 years ago)

Author:

obenland

Message:

Plugin Directory: Attachments are not 0-based but ID-based.

Makes sure that the submitted zip file gets read and removed when publishing
a new plugin.

See #1570.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php

@@ -3 +3 @@
 use WordPressdotorg\Plugin_Directory\Tools;
 use WordPressdotorg\Plugin_Directory\Tools\SVN;
+use WordPressdotorg\Plugin_Directory\Tools\Filesystem;
 
 /**
@@ -50 +51 @@
 
         // Read zip and add/commit files to svn.
-        $attachments   = get_attached_media( 'application/zip', $post_id );
-        $attachment_id = $attachments[0]->ID;
-        SVN::add( Filesystem::unzip( get_attached_file( $attachment_id ) ) );
+        $attachments = get_attached_media( 'application/zip', $post_id );
+        $attachment  = current( $attachments );
+        SVN::add( Filesystem::unzip( get_attached_file( $attachment->ID ) ) );
 
         // Delete zip.
-        wp_delete_attachment( $attachment_id, true );
+        wp_delete_attachment( $attachment->ID, true );
 
         // Grant commit access.