Changeset 2991

Timestamp:

04/21/2016 05:57:55 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Add a shim to allow us to retrieve the downloads count from postmeta (although the count is stored elsewhere for now).

See #1596

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/list-table/class-plugin-posts.php (modified) (1 diff)
• class-plugin-directory.php (modified) (2 diffs)
• class-template.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

@@ -199 +199 @@
      */
     public function column_downloads( $post ) {
-        if ( ! empty( $this->plugin_meta->downloaded ) ) {
-            echo number_format_i18n( $this->plugin_meta->downloaded );
-        }
+        echo number_format_i18n( get_post_meta( $post->ID, 'downloads', true ) );
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -29 +29 @@
 
         add_filter( 'map_meta_cap', array( __NAMESPACE__ . '\Capabilities', 'map_meta_cap' ), 10, 4 );
+
+        // Shim in postmeta support for data which doesn't yet live in postmeta
+        add_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ), 10, 4 );
 
         // Load the API routes
@@ -405 +408 @@
     }
 
+
+    /**
+     * Shim in some postmeta values which get retrieved from other locations temporarily.
+     *
+     * @param null|array|string $value     The value get_metadata() should return - a single metadata value,
+     *                                     or an array of values.
+     * @param int               $object_id Object ID.
+     * @param string            $meta_key  Meta key.
+     * @param bool              $single    Whether to return only the first value of the specified $meta_key.
+     */
+    public function filter_shim_postmeta( $value, $object_id, $meta_key, $single ) {
+        switch ( $meta_key ) {
+            case 'downloads':
+                $post = get_post( $object_id );
+                $count = Template::get_downloads_count( $post );
+
+                return $single ? $count : array( $count );              
+                break;
+        }
+        return $value;
+    }
+
     /**
      * Returns an array of pages based on section comments in the content.

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -20 +20 @@
 
     /**
+     * @param \WP_Post|int $post Optional.
+     * @return int
+     */
+    static function get_downloads_count( $post = null ) {
+        $post = get_post( $post );
+
+        if ( false === ( $count = wp_cache_get( $post->ID, 'plugin_download_count' ) ) ) {
+            global $wpdb;
+
+            // TODO: While the plugin ZIPs are still being served by bbPress, the download stats are stored there.
+            $count = $wpdb->get_var( $wpdb->prepare( "SELECT downloads FROM `" . PLUGINS_TABLE_PREFIX . "download_counts` WHERE topic_id = (SELECT topic_id FROM `" . PLUGINS_TABLE_PREFIX . "topics` WHERE topic_slug = %s )", $post->post_name ) );
+
+            wp_cache_set( $post->ID, $count, 'plugin_download_count', HOUR_IN_SECONDS );
+        }
+
+        return (int) $count;
+    }
+
+    /**
      * @return int
      */
@@ -26 +45 @@
             global $wpdb;
 
-            $count = $wpdb->get_var( "SELECT SUM(downloads) FROM `plugin_2_stats`" );
-            wp_cache_add( 'plugin_download_count', $count, 'plugin_download_count', DAY_IN_SECONDS );
+            $count = $wpdb->get_var( "SELECT SUM(downloads) FROM `" . PLUGINS_TABLE_PREFIX . "stats`" );
+            wp_cache_set( 'plugin_download_count', $count, 'plugin_download_count', DAY_IN_SECONDS );
         }