Changeset 2994 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

Timestamp:

04/21/2016 07:41:53 PM (9 years ago)

Author:

obenland

Message:

Plugin Directory: Housekeeping.

• Updates and corrects doc blocks.
• Simplifies overqualified class references.
• Corrects function args and return types.
• Adds missing labels to input elements.
• Makes sure variables are set before using them.

See #1584.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

@@ -8 +8 @@
 
     /**
-     * Plugin API response about the current plugin displayed.
-     *
-     * @var object
-     */
-     protected $plugin_meta;
-
-    /**
-     *
-     * @global array    $avail_post_stati
-     * @global WP_Query $wp_query
-     * @global int      $per_page
-     * @global string   $mode
+     *
+     * @global array     $avail_post_stati
+     * @global \WP_Query $wp_query
+     * @global int       $per_page
+     * @global string    $mode
      */
     public function prepare_items() {
@@ -137 +130 @@
             $classes[] = 'level-0';
         }
-
-        //@TODO: Switch to using the API class directly (once rewritten), or even better, post meta.
-        require_once ABSPATH . '/wp-admin/includes/plugin-install.php';
-        $this->plugin_meta = \plugins_api( 'plugin_information', array(
-            'slug'   => $post->post_name,
-        ) );
         ?>
         <tr id="post-<?php echo $post->ID; ?>" class="<?php echo implode( ' ', get_post_class( $classes, $post->ID ) ); ?>">
@@ -172 +159 @@
      */
     public function column_rating( $post ) {
-        if ( ! empty( $this->plugin_meta->rating ) && function_exists( 'wporg_get_dashicons_stars' ) ) {
-            echo wporg_get_dashicons_stars( $this->plugin_meta->rating / 20 );
+        $rating = (string) get_post_meta( $post->ID, 'avg_rating', true );
+        if ( ! empty( $rating ) && function_exists( 'wporg_get_dashicons_stars' ) ) {
+            echo wporg_get_dashicons_stars( $rating / 20 );
         }
     }
@@ -306 +294 @@
              *                         'Edit', 'Quick Edit', 'Restore, 'Trash',
              *                         'Delete Permanently', 'Preview', and 'View'.
-             * @param WP_Post $post The post object.
+             * @param \WP_Post $post The post object.
              */
             $actions = apply_filters( 'page_row_actions', $actions, $post );
@@ -319 +307 @@
              *                         'Edit', 'Quick Edit', 'Restore, 'Trash',
              *                         'Delete Permanently', 'Preview', and 'View'.
-             * @param WP_Post $post The post object.
+             * @param \WP_Post $post The post object.
              */
             $actions = apply_filters( 'post_row_actions', $actions, $post );