Changeset 3046

Timestamp:

04/29/2016 09:38:10 AM (8 years ago)

Author:

ocean90

Message:

Translate, Plugin Directory: Make Slack notification more verbose in case of errors.

See #1636.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php

@@ -53 +53 @@
         $time = date( 'r' );
         $message = "_Time: {$time}_\nTranslation sync from {$sub_project} to {$sub_project_counterpart} in process...\n";
+        $updates = 0;
         foreach ( $translation_sets as $translation_set ) {
             if ( 0 == $translation_set->current_count() ) {
@@ -60 +61 @@
             // Sync translations in a separate process.
             $cmd = WPORGTRANSLATE_WPCLI . ' wporg-translate sync-plugin-translations ' . escapeshellarg( $args['gp_project'] ) . ' ' . escapeshellarg( $translation_set->locale ) . ' --set=' . escapeshellarg( $translation_set->slug );
-            $output = shell_exec( $cmd );
-            if ( 'No translations available.' !== $output ) {
-                $message .= "\t" . $output;
-            }
-        }
+            $output = '';
+            $return_var = 0;
+            exec( $cmd, $output, $return_var );
+            if ( $return_var ) {
+                $message .= "\tFailure: " . implode( "\n\t", $output ) . "\n";
+            } else {
+                $message .= "\t" . implode( "\n\t", $output ) . "\n";
+            }
+            $updates += 1;
+        }
+
+        if ( ! $updates ) {
+            $message .= "\tNo translations are available to sync.\n";
+        }
+
         $message .= 'Translation sync was successfully processed.';