Changeset 3072 for sites/trunk/common/includes/slack/trac/comment-handler.php

Timestamp:

05/03/2016 02:10:07 PM (8 years ago)

Author:

ocean90

Message:

Slack: Don't remove the first line if the Trac mail is base64 encoded.

If the mail is base64 encoded the first line contains the title and is *not* empty.

Fixes #838.

File:

• sites/trunk/common/includes/slack/trac/comment-handler.php (modified) (2 diffs)

sites/trunk/common/includes/slack/trac/comment-handler.php

@@ -30 +30 @@
     function process_message() {
         $lines = array_map( 'rtrim', $this->lines );
+        $base64 = false;
 
         // Trim off headers.
@@ -49 +50 @@
         }
 
-        if ( ! empty( $base64 ) ) {
+        if ( $base64 ) {
             $lines = explode( "\n", base64_decode( implode( "\n", $lines ) ) );
         }
 
-        // Remove empty line between headers and body.
-        array_shift( $lines );
+        // Remove empty line between headers and body if not base64.
+        if ( ! $base64 ) {
+            array_shift( $lines );
+        }
 
         $title = '';