Changeset 3086

Timestamp:

05/05/2016 11:38:55 AM (7 years ago)

Author:

ocean90

Message:

Slack: Avoid two PHP notices when the Trac email doesn't contain a (Comment|Changes|Description changed) line.

See #1368.

File:

• sites/trunk/common/includes/slack/trac/comment-handler.php (modified) (1 diff)

sites/trunk/common/includes/slack/trac/comment-handler.php

@@ -99 +99 @@
 
         preg_match( '/^(Comment|Changes|Description changed) \(?by (.*[^\)])\)?:$/', array_shift( $lines ), $matches );
-        $has_changes = $matches[1] === 'Changes';
-        $author = $matches[2];
+        $has_changes = ( isset( $matches[1] ) && 'Changes' === $matches[1] );
+        $author = isset( $matches[2] ) ? $matches[2] : '';
 
         // Remove blank line after 'Comment|Changes (by author):' or 'Description changed by author:'.