Changeset 3087 for sites/trunk/common/includes/slack/trac/comment-handler.php

Timestamp:

05/05/2016 12:59:30 PM (8 years ago)

Author:

ocean90

Message:

Slack: Improve notifications for ticket summary changes.

• Parse the subject of a Trac mail because it's the only place where summary changes are mentioned.
• Include ticket summary changes in the "changes" section.
• Fall back to "Someone" if the author property isn't set. That's the case for summary only changes.

Fixes #1368.

File:

• sites/trunk/common/includes/slack/trac/comment-handler.php (modified) (4 diffs)

sites/trunk/common/includes/slack/trac/comment-handler.php

@@ -31 +31 @@
         $lines = array_map( 'rtrim', $this->lines );
         $base64 = false;
+        $subject = '';
 
         // Trim off headers.
@@ -47 +48 @@
             } elseif ( 0 === strpos( $line, 'Content-Transfer-Encoding: base64' ) ) {
                 $base64 = true;
+            } elseif ( 0 === strpos( $line, 'Subject:' ) ) {
+                $subject = str_replace( 'Subject: ', '', $line );
+
+                $subject_lines = $lines;
+                while ( $subject_lines && ! preg_match( '/(^[\x21-\x7E][^:]+):/', current( $subject_lines ) ) ) {
+                    $subject .= array_shift( $subject_lines );
+                }
+                unset( $subject_lines );
             }
         }
@@ -106 +115 @@
 
         $changes = $comment = array();
+
+        // Check if the summary of a ticket was changed.
+        if ( preg_match( '/ \(was: (.*)\)$/', $subject, $matches ) ) {
+            $changes[] = '_*summary:*_ ' . $matches[1] . ' => ' . $title;
+        }
+
         if ( $has_changes ) {
             while ( $lines && '' !== current( $lines ) ) {
@@ -157 +172 @@
         $comment         = $this->format_comment_for_slack();
         $main_attachment = $this->changes ? implode( "\n", $this->changes ) : $comment;
-        $pretext         = sprintf( '*%s updated <%s|#%s %s>*', $this->author, $this->comment_url, $this->ticket_id, htmlspecialchars( $this->title, ENT_NOQUOTES ) );
+        $author          = $this->author ? $this->author : 'Someone';
+        $pretext         = sprintf( '*%s updated <%s|#%s %s>*', $author, $this->comment_url, $this->ticket_id, htmlspecialchars( $this->title, ENT_NOQUOTES ) );
         $fallback        = trim( $pretext, '*' ) . "\n" . $main_attachment;