Changeset 309

Timestamp:

01/24/2014 04:21:04 AM (11 years ago)

Author:

nacin

Message:

Trac: Explicitly sort fields on the ticket screen.

This positioning is necessary for rendering the focus field. But this also results in some good pairings. Milestone and priority are on the same row (and both are disabled for non-gardeners). Priority and severity are adjacent. So are focuses and components, and focuses and keywords.

see #287.

File:

• sites/trunk/trac.wordpress.org/templates/site.html (modified) (1 diff)

sites/trunk/trac.wordpress.org/templates/site.html

@@ -33 +33 @@
     except (IndexError, KeyError):
         pass
+
+    field_types = [ 'milestone', 'priority', 'type', 'severity', 'version', 'component', 'keywords', 'focuses', ]
+
+    # Sorting function
+    def sort_nicely(field1, field2):
+        try:
+            idx1 = field_types.index(field1['name'])
+        except ValueError:
+            idx1 = 1000 # no match, push to the end
+
+        try:
+            idx2 = field_types.index(field2['name'])
+        except ValueError:
+            idx2 = 1000 # no match, push to the end
+
+        return cmp(idx1, idx2)
+
+    if ticket and 'fields' in locals():
+        # Sort the fields
+        fields.sort(cmp=sort_nicely)
+
+        # Re-generate fields_map for use within the ticket template
+        fields_map = {}
+        for i in xrange(0, len(fields)):
+            fields_map[ fields[i]['name'] ] = i
 ?>