Changeset 3279 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/extras.php

Timestamp:

05/31/2016 07:45:40 PM (10 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Fix document title generation.

• Fix conditional to properly check for handbook home page so title can be assigned the handbook's name.
• Prepend separator later so as not to interfere with string comparisons.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/extras.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/extras.php

@@ -65 +65 @@
     }
     // Add handbook name to title if relevent
-    elseif ( is_singular() && false !== strpos( $post_type, 'handbook' ) ) {
+    elseif ( ( is_singular() || is_post_type_archive() ) && false !== strpos( $post_type, 'handbook' ) ) {
         if ( $post_type_object = get_post_type_object( $post_type ) ) {
-            $handbook_label = " $sep " . get_post_type_object( $post_type )->labels->name;
-            $handbook_name  = " $sep " . \WPorg_Handbook::get_name( $post_type ) . " Handbook";
+            $handbook_label = get_post_type_object( $post_type )->labels->name;
+            $handbook_name  = \WPorg_Handbook::get_name( $post_type ) . " Handbook";
 
             // Replace title with handbook name if this is landing page for the handbook
@@ -75 +75 @@
             // Otherwise, append the handbook name
             } else {
-                $title .= $handbook_name;
+                $title .= " $sep " . $handbook_name;
             }
         }