Changeset 3288

Timestamp:

06/01/2016 10:00:11 PM (9 years ago)

Author:

iandunn

Message:

WordCamp QBO Client: Bump remote request timeout to 10 seconds.

There have been several cases where requests timed out after 5 seconds, even though the remote server received and fully processed them. Because the server sent its response after the timeout, the client handled it as an error, which resulted in duplicate invoices being created in QuickBooks.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo-client/wordcamp-qbo-client.php (modified) (6 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo-client/wordcamp-qbo-client.php

@@ -7 +7 @@
 
 class WordCamp_QBO_Client {
+    const REMOTE_REQUEST_TIMEOUT = 10; // seconds
+
     private static $hmac_key;
     private static $api_base;
@@ -95 +97 @@
         $request_url = esc_url_raw( self::$api_base . '/classes/' );
         $request_args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Content-Type' => 'application/json',
@@ -242 +245 @@
         $request_url = esc_url_raw( self::$api_base . '/expense/' );
         $request_args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'body' => $body,
             'headers' => array(
@@ -357 +361 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => $oauth_header,
@@ -431 +436 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => self::_get_auth_header( 'get', $request_url, '', $params ),
@@ -488 +494 @@
 
         $args = array(
+            'timeout' => self::REMOTE_REQUEST_TIMEOUT,
             'headers' => array(
                 'Authorization' => self::_get_auth_header( 'get', $request_url, '', $params ),