Changeset 3321 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-builder.php

Timestamp:

06/09/2016 04:37:58 AM (9 years ago)

Author:

dd32

Message:

Plugin Directory: When building ZIP files, use a custom implementation of tempnam() to accomodate plugins which have longer filenames.
Previously a plugin with a slug and version combination exceeding 60 characters would cause a build failure.
See #1578

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-builder.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/zip/class-builder.php

@@ -58 +58 @@
     public function build() {
         try {
-            // The name must have at least 1 `.` in it for CLI `zip` not to complain.
-            $this->tmp_build_file = tempnam( dirname( $this->zip_file ), "tmp-{$this->slug}.{$this->version}" );
+            $this->tmp_build_file = $this->generate_temporary_filename( dirname( $this->zip_file ), "tmp-{$this->slug}.{$this->version}", '.zip' );
             $this->tmp_build_dir  = $this->tmp_build_file . '-files';
             mkdir( $this->tmp_build_dir, 0777, true );
@@ -78 +77 @@
             $this->cleanup();
         }*/
+    }
+
+    /**
+     * Generates a temporary unique file in a given directory
+     *
+     * Performs a similar job to `tempnam()` with an added suffix and doesn't
+     * cut off the $prefix at 60 characters.
+     * As with `tempnam()` the caller is responsible for removing the temorarily file.
+     *
+     * Note: `strlen( $prefix . $suffix )` shouldn't exceed 238 characters.
+     *
+     * @param string $dir The directory to create the file in.
+     * @param string $prefix The file prefix.
+     * @param string $suffix The file suffix, optional.
+     *
+     * @return string Filename of unique temporary file.
+     */
+    protected function generate_temporary_filename( $dir, $prefix, $suffix = '' ) {
+        $i = 0;
+        do {
+            $rand = uniqid();
+            $filename = "{$dir}/{$prefix}-{$rand}{$i}{$suffix}";
+        } while ( false === ($fp = @fopen( $filename, 'x' ) ) && $i++ < 50 );
+
+        if ( $i >= 50 ) {
+            throw new Exception( __METHOD__ . ': Could not find unique filename.' );
+        }
+
+        fclose( $fp );
+
+        return $filename;
     }