Changeset 3338 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

Timestamp:

06/12/2016 10:15:16 AM (8 years ago)

Author:

obenland

Message:

Plugin Directory: Treat plugin sections like the archive they are.

Adds a special case for the term 'popular' to not require the term to be
assigned to a plugin for the plugin to show up in the term archive.

Fixes #1757.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -99 +99 @@
         register_taxonomy( 'plugin_section', 'plugin', array(
             'hierarchical'      => true,
-            'query_var'         => 'plugin_section',
+            'query_var'         => 'browse',
             'rewrite'           => false,
             'public'            => true,
@@ -109 +109 @@
             ),
             'labels'            => array(
-                'name' => __( 'Plugin Sections', 'wporg-plugins' ),
+                'name' => __( 'Browse', 'wporg-plugins' ),
             ),
         ) );
@@ -409 +409 @@
 
         switch ( get_query_var( 'browse' ) ) {
-            case 'beta':
-                $wp_query->query_vars['plugin_section'] = 'beta';
-                break;
-
-            case 'featured':
-                $wp_query->query_vars['plugin_section'] = 'featured';
-                break;
-
             case 'favorites':
                 $favorites_user = get_current_user_id();
@@ -442 +434 @@
                 $wp_query->query_vars['orderby'] = 'meta_value_num';
                 $wp_query->query_vars['meta_key'] = 'active_installs';
+
+                add_filter( 'posts_where', array( $this, 'pre_get_posts_sql_browse_popular' ) );
                 break;
         }
-
+    }
+
+    /**
+     * Custom callback for pre_get_posts to remove the requirement for plugins to be tagged
+     * 'popular' to show up when browsing popular plugins.
+     *
+     * @ignore
+     *
+     * @param string $where WHERE clause.
+     * @return string
+     */
+    public function pre_get_posts_sql_browse_popular( $where ) {
+        global $wpdb;
+
+        remove_filter( 'posts_where', array( $this, 'pre_get_posts_sql_browse_popular' ) );
+        $term = get_term_by( 'slug', 'popular', 'plugin_section' );
+
+        return str_replace( " AND ( \n  {$wpdb->term_relationships}.term_taxonomy_id IN ({$term->term_id})\n)", '', $where );
     }
 
@@ -613 +624 @@
     /**
      * Filters the value of tax_inputs before saving.
-     * 
+     *
      * Used both in the admin and the uploader.
      *