Changeset 3343

Timestamp:

06/13/2016 06:18:01 PM (10 years ago)

Author:

obenland

Message:

Plugin Directory: Allow users to browse their favorite plugins.

See #1573.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -427 +427 @@
                                         $wp_query->query_vars['p'] = -1;
                                 }
+
+                                add_filter( 'posts_where', array( $this, 'pre_get_posts_sql_browse' ) );
                                 break;
 
                         case 'popular':
-                                add_filter( 'posts_where', array( $this, 'pre_get_posts_sql_browse_popular' ) );
+                                add_filter( 'posts_where', array( $this, 'pre_get_posts_sql_browse' ) );
                                 break;
                 }
@@ -441 +443 @@
 
         /**
-         * Custom callback for pre_get_posts to remove the requirement for plugins to be tagged
-         * 'popular' to show up when browsing popular plugins.
+         * Callback to remove the requirement for plugins to be tagged with the requested
+         * plugin_section term.
+         *
+         * Used for archives like `popular` or `favorites`, that all active plugins are a part of.
          *
          * @ignore
@@ -449 +453 @@
          * @return string
          */
-        public function pre_get_posts_sql_browse_popular( $where ) {
+        public function pre_get_posts_sql_browse( $where ) {
                 global $wpdb;
 
-                remove_filter( 'posts_where', array( $this, 'pre_get_posts_sql_browse_popular' ) );
-                $term = get_term_by( 'slug', 'popular', 'plugin_section' );
-
-                return str_replace( " AND ( \n  {$wpdb->term_relationships}.term_taxonomy_id IN ({$term->term_id})\n)", '', $where );
+                remove_filter( 'posts_where', array( $this, 'pre_get_posts_sql_browse' ) );
+
+                $term = get_term_by( 'slug', get_query_var( 'browse' ), 'plugin_section' );
+
+                if ( $term instanceof \WP_Term ) {
+                        $where = str_replace( " AND ( \n  {$wpdb->term_relationships}.term_taxonomy_id IN ({$term->term_id})\n)", '', $where );
+                }
+
+                return $where;
         }