Changeset 3378

Timestamp:

06/15/2016 08:30:23 AM (10 years ago)

Author:

dd32

Message:

Plugin Directory: Sort by the raw active install count to ensure that we get a consistent ordering, this prevents something being on page x and page x+1 because the paginated query ordered the results differently.

See #1719

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/plugin-directory/class-plugin-directory.php (modified) (1 diff)
• themes/pub/wporg-plugins/front-page.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -447 +447 @@
                 if ( $wp_query->is_archive() && empty( $wp_query->query_vars['orderby'] ) ) {
                         $wp_query->query_vars['orderby']  = 'meta_value_num';
-                        $wp_query->query_vars['meta_key'] = 'active_installs';
+                        $wp_query->query_vars['meta_key'] = '_active_installs';
                 }
         }

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/front-page.php

@@ -33 +33 @@
                         );
 
-                        if ( 'popular' === $browse ) :
-                                $section_args['meta_key'] = 'active_installs';
+                        if ( 'popular' === $browse ) {
+                                $section_args['meta_key'] = '_active_installs';
                                 $section_args['orderby']  = 'meta_value_num';
                                 unset( $section_args['browse'] );
-                        endif;
+                        }
 
                         $section_query = new \WP_Query( $section_args );