Changeset 3418

Timestamp:

06/17/2016 04:45:49 PM (5 years ago)

Author:

obenland

Message:

Plugin Directory: Highlight current menu item.

See #1719.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins

Files:

• css/style-rtl.css (modified) (1 diff)
• css/style.css (modified) (1 diff)
• header.php (modified) (2 diffs)
• sass/navigation/_menus.scss (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/css/style-rtl.css

@@ -1279 +1279 @@
 }
 
-.main-navigation a.active, .main-navigation .single .type-plugin .entry-content .active.section-toggle, .single .type-plugin .entry-content .main-navigation .active.section-toggle {
-  border-color: rgba(255, 255, 255, 0.2);
+@media screen and (min-width: 48em) {
+  .main-navigation a.active, .main-navigation .single .type-plugin .entry-content .active.section-toggle, .single .type-plugin .entry-content .main-navigation .active.section-toggle {
+    border-bottom: 1px solid;
+  }
 }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/css/style.css

@@ -1279 +1279 @@
 }
 
-.main-navigation a.active, .main-navigation .single .type-plugin .entry-content .active.section-toggle, .single .type-plugin .entry-content .main-navigation .active.section-toggle {
-  border-color: rgba(255, 255, 255, 0.2);
+@media screen and (min-width: 48em) {
+  .main-navigation a.active, .main-navigation .single .type-plugin .entry-content .active.section-toggle, .single .type-plugin .entry-content .main-navigation .active.section-toggle {
+    border-bottom: 1px solid;
+  }
 }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/header.php

@@ -11 +11 @@
 
 namespace WordPressdotorg\Plugin_Directory\Theme;
+
+$menu_items = array(
+    '/browse/favorites/' => __( 'Favorites', 'wporg-plugins' ),
+    '/browse/beta/'      => __( 'Beta Testing', 'wporg-plugins' ),
+    '/about/'            => __( 'Developers', 'wporg-plugins' ),
+);
 
 $GLOBALS['pagetitle'] = __( 'Plugin Directory — Free WordPress Plugins', 'wporg-plugins' );
@@ -34 +40 @@
                     <div id="primary-menu" class="menu">
                         <ul>
-                            <li class="page_item"><a href="<?php echo esc_url( home_url( 'browse/favorites/' ) ); ?>"><?php esc_html_e( 'Favorites', 'wporg-plugins' ); ?></a></li>
-                            <li class="page_item"><a href="<?php echo esc_url( home_url( 'browse/beta/' ) ); ?>"><?php esc_html_e( 'Beta Testing', 'wporg-plugins' ); ?></a></li>
-                            <li class="page_item"><a href="<?php echo esc_url( home_url( 'about/' ) ); ?>"><?php esc_html_e( 'Developers', 'wporg-plugins' ); ?></a></li>
+                            <?php
+                            foreach ( $menu_items as $path => $text ) :
+                                $class = false !== strpos( $_SERVER['REQUEST_URI'], $path ) ? 'class="active" ' : '';
+                            ?>
+                            <li class="page_item"><a <?php echo $class; ?>href="<?php echo esc_url( home_url( $path ) ); ?>"><?php echo esc_html( $text ); ?></a></li>
+                            <?php endforeach; ?>
                             <li><?php get_search_form(); ?></li>
                         </ul>

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/sass/navigation/_menus.scss

@@ -75 +75 @@
         }
 
-        &.active {
-            border-color: rgba( 255, 255, 255, 0.2 );
+        @media screen and (min-width: $ms-breakpoint) {
+            &.active {
+                border-bottom: 1px solid;
+            }
         }
     }