Changeset 3456

Timestamp:

06/19/2016 10:19:37 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Move the /about/ page to /developers/

See #1584

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/plugin-directory/class-plugin-directory.php (modified) (2 diffs)
• plugins/plugin-directory/shortcodes/class-upload-handler.php (modified) (1 diff)
• themes/pub/wporg-plugins/header.php (modified) (1 diff)
• themes/pub/wporg-plugins/page-developers.php (moved) (moved from sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/page-about.php) (3 diffs)
• themes/pub/wporg-plugins/template-parts/plugin-single.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -636 +636 @@
             die();
         }
-        // We don't have attachments, but /$plugin/random() will hit this check.
+
+        // We've disabled WordPress's default 404 redirects, so we'll handle them ourselves.
         if ( is_404() ) {
 
@@ -655 +656 @@
             }
 
+            // The about page is now over at /developers/
+            if ( 'about' === $path[2] ) {
+                wp_safe_redirect( home_url('/developers/' . ( ( isset( $path[3] ) && 'add' == $path[3] ) ? 'add/' : '' ) ) );
+                die();
+            }
+
+            // Otherwise, handle a plugin redirect
             if ( $plugin = self::get_plugin_post( $path[2] ) ) {
                 $is_disabled = in_array( $plugin->post_status, array( 'disabled', 'closed' ), true );

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-upload-handler.php

@@ -245 +245 @@
             'updated',
             'about',
+            'developers',
             'admin',
             'wp-admin',

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/header.php

@@ -16 +16 @@
     '/browse/favorites/' => __( 'My Favorites', 'wporg-plugins' ),
     '/browse/beta/'      => __( 'Beta Testing', 'wporg-plugins' ),
-    '/about/'            => __( 'Developers', 'wporg-plugins' ),
+    '/developers/'       => __( 'Developers', 'wporg-plugins' ),
 );
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/page-developers.php

@@ -1 +1 @@
 <?php
 /**
- * The template for the a out page.
+ * The template for the Developers page.
  *
  * @package WordPressdotorg\Plugin_Directory\Theme
@@ -22 +22 @@
                 <section>
                     <div class="container">
-                        <p><?php printf( __( 'You’ve got a cool new plugin and are hoping to give it some exposure. You’re in the right place. Just <a href="%s">ask us to host it for you</a>. You’ll be able to:', 'wporg-plugins' ), esc_url( home_url( 'about/add' ) ) ); ?></p>
+                        <p><?php printf( __( 'You’ve got a cool new plugin and are hoping to give it some exposure. You’re in the right place. Just <a href="%s">ask us to host it for you</a>. You’ll be able to:', 'wporg-plugins' ), esc_url( home_url( 'developers/add' ) ) ); ?></p>
                         <ul>
                             <li><?php _e( 'Keep track of how many people have downloaded it.', 'wporg-plugins' ); ?></li>
@@ -42 +42 @@
                         <ol>
                             <li><?php printf( __( '<a href="%s">Sign up</a> for an account on WordPress.org.', 'wporg-plugins' ), esc_url( 'https://wordpress.org/support/register.php' ) ); ?></li>
-                            <li><?php printf( __( '<a href="%s">Submit your plugin for review</a>.', 'wporg-plugins' ), esc_url( home_url( 'about/add' ) ) ); ?></li>
+                            <li><?php printf( __( '<a href="%s">Submit your plugin for review</a>.', 'wporg-plugins' ), esc_url( home_url( 'developers/add' ) ) ); ?></li>
                             <li><?php printf( __( 'After your plugin is <a href="%s">manually reviewed</a>, you will either be approved or emailed and asked to provide more information and/or make corrections.', 'wporg-plugins' ), esc_url( 'https://developer.wordpress.org/plugins/wordpress-org/plugin-developer-faq/#questions-about-submissions-and-approval' ) ); ?></li>
                             <li><?php printf( __( 'Once approved, you’ll be given access to a <a id="subversion" href="%s">Subversion Repository</a> where you’ll store your plugin.', 'wporg-plugins' ), esc_url( 'https://developer.wordpress.org/plugins/wordpress-org/how-to-use-subversion/' ) ); ?></li>

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

@@ -12 +12 @@
 use WordPressdotorg\Plugin_Directory\Template;
 
-$content = call_user_func( array( Plugin_Directory::instance(), 'split_post_content_into_pages' ), get_the_content() );
+$content = Plugin_Directory::instance()->split_post_content_into_pages( get_the_content() );
 
 $widget_args = array(