Changeset 3556

Timestamp:

06/22/2016 03:21:57 PM (7 years ago)

Author:

ocean90

Message:

Plugin Directory: Change the API endpoint for locale banners to /locale-banner so it can be used for other requests.

See #1728.

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/plugin-directory/api/class-base.php (modified) (1 diff)
• plugins/plugin-directory/api/routes/class-locale-banner.php (moved) (moved from sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-translations.php) (3 diffs)
• themes/pub/wporg-plugins/functions.php (modified) (1 diff)
• themes/pub/wporg-plugins/js/locale-banner.js (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/class-base.php

@@ -14 +14 @@
         new Routes\Internal_Stats();
         new Routes\Plugin();
-        new Routes\Plugin_Translations();
+        new Routes\Locale_Banner();
         new Routes\Plugin_Favorites();
         new Routes\Commit_Subscriptions();

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-locale-banner.php

@@ -1 +1 @@
 <?php
 namespace WordPressdotorg\Plugin_Directory\API\Routes;
+use WordPressdotorg\Plugin_Directory\API\Base;
 use WP_REST_Server;
 
@@ -8 +9 @@
  * @package WordPressdotorg_Plugin_Directory
  */
-class Plugin_Translations extends Plugin {
+class Locale_Banner extends Base {
 
     function __construct() {
-        register_rest_route( 'plugins/v1', '/plugin/(?P<plugin_slug>[^/]+)/translations/?', array(
-            'methods'  => WP_REST_Server::READABLE,
-            'callback' => array( $this, 'translations' ),
+        register_rest_route( 'plugins/v1', '/locale-banner', array(
+            'methods'  => WP_REST_Server::EDITABLE,
+            'callback' => array( $this, 'locale_banner' ),
             'args' => array(
                 'plugin_slug' => array(
@@ -28 +29 @@
      * @return array A formatted array of all the data for the plugin.
      */
-    function translations( $request ) {
+    function locale_banner( $request ) {
         global $wpdb;
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php

@@ -76 +76 @@
         wp_enqueue_script( 'wporg-plugins-accordion', get_template_directory_uri() . '/js/section-accordion.js', array(), '20160525', true );
 
-        $slug = get_queried_object()->post_name;
-        wp_enqueue_script( 'wporg-plugins-locale-banner', get_template_directory_uri() . '/js/locale-banner.js', array(), '20160619', true );
+        wp_enqueue_script( 'wporg-plugins-locale-banner', get_template_directory_uri() . '/js/locale-banner.js', array(), '20160622', true );
         wp_localize_script( 'wporg-plugins-locale-banner', 'wporgLocaleBanner', array(
-            'apiURL' => rest_url( "/plugins/v1/plugin/$slug/translations" ),
+            'apiURL' => rest_url( '/plugins/v1/locale-banner' ),
+            'currentPlugin' => get_queried_object()->post_name,
         ) );
     }

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/js/locale-banner.js

@@ -3 +3 @@
 
     $.ajax({
+        type: 'POST',
         url : wporgLocaleBanner.apiURL,
         dataType : 'json',
+        data: {
+            'plugin_slug' : wporgLocaleBanner.currentPlugin
+        },
         success : function( response ) {
             if ( ! response.suggest_string ) {