Changeset 3810

Timestamp:

08/15/2016 06:46:02 PM (8 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Make get_uses() and get_used_by() consistently and properly honor $post argument.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php (modified) (5 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

@@ -1007 +1007 @@
 
     /**
-     * Retrieve a WP_Query object for the posts that the current post uses
-     *
-     * @return WP_Query A WP_Query object for the posts the current post uses
-     */
-    function get_uses() {
-        $post_type = get_post_type();
+     * Retrieves a WP_Query object for the posts that the current post uses.
+     *
+     * @param int|WP_Post|null $post Optional. Post ID or post object. Default is global $post.
+     * @return WP_Query|null   The WP_Query if the post's post type supports 'uses', null otherwise.
+     */
+    function get_uses( $post = null ) {
+        $post_id   = get_post_field( 'ID', $post );
+        $post_type = get_post_type( $post );
 
         if ( 'wp-parser-class' === $post_type ) {
-            $extends = get_post_meta( get_the_ID(), '_wp-parser_extends', true );
+            $extends = get_post_meta( $post_id, '_wp-parser_extends', true );
             if ( ! $extends ) {
                 return;
@@ -1034 +1036 @@
             'connected_type'      => $connection_types,
             'connected_direction' => array( 'from', 'from', 'from' ),
-            'connected_items'     => get_the_ID(),
+            'connected_items'     => $post_id,
             'nopaging'            => true,
         ) );
@@ -1041 +1043 @@
     }
 
-    function get_used_by( $post_id = null ) {
-
-        if ( empty( $post_id ) ) {
-            $post_id = get_the_ID();
-        }
-
-        switch ( get_post_type() ) {
+    /**
+     * Retrieves a WP_Query object for the posts that use the specified post.
+     *
+     * @param int|WP_Post|null $post Optional. Post ID or post object. Default is global $post.
+     * @return WP_Query|null   The WP_Query if the post's post type supports 'used by', null otherwise.
+     */
+    function get_used_by( $post = null ) {
+
+        switch ( get_post_type( $post ) ) {
 
             case 'wp-parser-function':
@@ -1065 +1069 @@
                     'post_type'  => array( 'wp-parser-class' ),
                     'meta_key'   => '_wp-parser_extends',
-                    'meta_value' => get_post_field( 'post_name', get_post( $post_id ) ),
+                    'meta_value' => get_post_field( 'post_name', $post ),
                 ) );
-                return $connected;  
+                return $connected;
                 break;
 
@@ -1079 +1083 @@
             'connected_type'      => $connection_types,
             'connected_direction' => array( 'to', 'to' ),
-            'connected_items'     => $post_id,
+            'connected_items'     => get_post_field( 'ID', $post ),
             'nopaging'            => true,
         ) );