Changeset 3902

Timestamp:

09/01/2016 03:00:35 AM (9 years ago)

Author:

jmdodd

Message:

Support Forums: Improve performance on individual topic and topic_title filters.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -73 +73 @@
     public function check_topic_for_compat() {
         if ( bbp_is_single_topic() ) {
-            $slug = wp_get_object_terms( bbp_get_topic_id(), $this->taxonomy(), array( 'fields' => 'slugs' ) );
-
-            // Match found for this compat.
-            if ( ! empty( $slug ) ) {
-                $slug = $slug[0];
+            $terms = get_the_terms( bbp_get_topic_id(), $this->taxonomy() );
+            if ( ! empty( $terms ) && ! is_wp_error( $terms ) ) {
+                $slug = $terms[0]->slug;
 
                 // Basic setup.
@@ -96 +94 @@
 
     public function get_topic_title( $title, $topic_id ) {
-        if ( bbp_is_single_topic() || ( bbp_is_single_view() && in_array( bbp_get_view_id(), array( $this->compat(), 'reviews', 'active' ) ) ) ) {
-            return $title;
-        }
-
-        $slug = wp_get_object_terms( $topic_id, $this->taxonomy(), array( 'fields' => 'slugs' ) );
-        if ( ! empty( $slug ) ) {
-            $slug = $slug[0];
-            $object = $this->get_object( $slug );
-            $title = sprintf( "[%s] %s", esc_html( $object->post_title ), esc_html( $title ) );
+        if (
+            ( bbp_is_single_forum() && bbp_get_forum_id() == $this->forum_id() )
+        ||
+            ( bbp_is_single_view() && ! in_array( bbp_get_view_id(), array( $this->compat(), 'reviews', 'active' ) ) )
+        ) {
+            $terms = get_the_terms( $topic_id, $this->taxonomy() );
+            if ( ! empty( $terms ) && ! is_wp_error( $terms ) ) {
+                $term = $terms[0];
+                $object = $this->get_object( $term->slug );
+                $title = sprintf( "[%s] %s", esc_html( $object->post_title ), esc_html( $title ) );
+            }
         }
         return $title;