Changeset 3968 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments-network/includes/sponsor-invoices-dashboard.php

Timestamp:

09/05/2016 07:59:47 PM (8 years ago)

Author:

iandunn

Message:

WordCamp Budgets Dashboard: Check for paid invoices in batches

The previous limit of 100 was too small, because we currently have 150 pending invoices, and the latter third weren't being checked.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments-network/includes/sponsor-invoices-dashboard.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments-network/includes/sponsor-invoices-dashboard.php

@@ -249 +249 @@
 
     $table_name = get_index_table_name();
-
-    /*
-     * This query is limited at 100 rows to avoid requesting too much data from QBO. In most cases it shouldn't be
-     * a problem, but it's possible that at some point the number of pending invoices will exceed the limit, and
-     * we'll need to refactor this to update them in batches.
-     */
+    $paid_invoices = array();
+
     $sent_invoices = $wpdb->get_results( "
         SELECT blog_id, invoice_id, qbo_invoice_id
         FROM $table_name
         WHERE status = 'wcbsi_approved'
-        LIMIT 100
+        LIMIT 1000
     " );
 
-    $paid_invoices = \WordCamp_QBO_Client::get_paid_invoices(
-        wp_list_pluck( $sent_invoices, 'qbo_invoice_id' )
-    );
+    // Batch requests in order to avoid request size limits imposed by QuickBooks, nginx, etc
+    $qbo_invoice_ids = wp_list_pluck( $sent_invoices, 'qbo_invoice_id' );
+    $qbo_invoice_ids = array_chunk( $qbo_invoice_ids, 20 );
+
+    foreach( $qbo_invoice_ids as $batch ) {
+        $paid_invoices = array_merge(
+            $paid_invoices,
+            \WordCamp_QBO_Client::get_paid_invoices( $batch )
+        );
+
+        usleep( 300000 );   // Avoid hitting the API too frequently
+    }
 
     mark_invoices_as_paid( $sent_invoices, $paid_invoices );