Changeset 402 for sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php

Timestamp:

02/19/2014 02:37:07 PM (12 years ago)

Author:

nacin

Message:

Trac Notifications: Ignore CCs when calculating ticket participants.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php

@@ -85 +85 @@
 
     function get_trac_ticket_participants( $ticket_id ) {
-        return $this->trac->get_col( $this->trac->prepare( "SELECT DISTINCT author FROM ticket_change WHERE ticket = %d", $ticket_id ) );
+        // Make sure we suppress CC-only comments that still exist in the database.
+        // Do this by suppressing any 'cc' changes and also any empty comments (used by Trac for comment numbering).
+        // Empty comments are also used for other property changes made without comment, but those changes will still be returned by this query.
+        $ignore_cc = "field <> 'cc' AND NOT (field = 'comment' AND newvalue = '') AND";
+        return $this->trac->get_col( $this->trac->prepare( "SELECT DISTINCT author FROM ticket_change WHERE $ignore_cc ticket = %d", $ticket_id ) );
     }