Changeset 4023

Timestamp:

09/09/2016 05:59:50 PM (7 years ago)

Author:

jmdodd

Message:

Support Forums: Enable "active" view and feed for plugin and theme support forums.

This view only includes open topics to help with performance.

If it causes issues, the feed and view can be temporarily disabled or the timeframe brought down to six months.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc

Files:

• class-directory-compat.php (modified) (8 diffs)
• class-performance-optimizations.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php

@@ -59 +59 @@
 
             // Compat views are hooked in a special order, and need help with feed queries.
-            if ( isset( $query_vars['bbp_view'] ) && in_array( $query_vars['bbp_view'], array( $this->compat(), 'reviews' ) ) ) {
+            if ( isset( $query_vars['bbp_view'] ) && in_array( $query_vars['bbp_view'], array( $this->compat(), 'reviews', 'active' ) ) ) {
                 $this->query = $query_vars;
                 add_filter( 'bbp_get_view_query_args', array( $this, 'get_view_query_args_for_feed' ), 10, 2 );
@@ -79 +79 @@
                     ) ),
                     'show_stickies'  => false,
+                    'orderby'        => 'ID',
                 );
                 break;
@@ -86 +87 @@
                 return array(
                     'post_parent'    => Plugin::REVIEWS_FORUM_ID,
+                    'tax_query'      => array( array(
+                        'taxonomy'   => $this->taxonomy(),
+                        'field'      => 'slug',
+                        'terms'      => $this->query[ $this->query_var() ],
+                    ) ),
+                    'show_stickies'  => false,
+                    'orderby'        => 'ID',
+                );
+                break;
+
+            // Return active topics from the support forum.
+            case 'active' :
+                return array(
+                    'post_parent'    => $this->forum_id(),
+                    'post_status'    => 'publish',
                     'tax_query'      => array( array(
                         'taxonomy'   => $this->taxonomy(),
@@ -244 +260 @@
                 ) ),
                 'show_stickies' => false,
+                'meta_key'      => null,
+                'meta_compare'  => null,
                 'orderby'       => 'ID',
             )
@@ -260 +278 @@
                 ) ),
                 'show_stickies' => false,
+                'meta_key'      => null,
+                'meta_compare'  => null,
                 'orderby'       => 'ID',
             )
@@ -270 +290 @@
             array(
                 'post_parent'   => $this->forum_id(),
-                'meta_query'    => array( array(
-                    'key'       => '_bbp_last_active_time',
-                    'type'      => 'DATETIME',
-                ) ),
+                'post_status'   => 'publish',
                 'tax_query'     => array( array(
                     'taxonomy'  => $this->taxonomy(),
@@ -280 +297 @@
                 ) ),
                 'show_stickies' => false,
-                'orderby'       => 'meta_value',
             )
         );
@@ -336 +352 @@
         $r[1] = '<a href="' . esc_url( bbp_get_forum_permalink( $this->forum_id() ) ) . '" class="bbp-breadcrumb-forum">' . esc_html( bbp_get_forum_title( $this->forum_id() ) ) . '</a>';
         $r[2] = esc_html( $this->title() );
-        if ( 'reviews' == $view ) {
+        if ( in_array( $view, array( 'reviews', 'active' ) ) ) {
             $r[2] = '<a href="' . esc_url( bbp_get_view_url( $this->compat() ) ) . '" class="bbp-breadcrumb-forum">' . esc_html( $this->title() ) . '</a>';
-            $r[3] = __( 'Reviews', 'wporg-forums' );
+            if ( 'reviews' == $view ) {
+                $r[3] = __( 'Reviews', 'wporg-forums' );
+            } else {
+                $r[3] = __( 'Active Topics', 'wporg-forums' );
+            }
         }
         return $r;

sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php

@@ -126 +126 @@
          */
         if ( isset( $r['post_type'] ) && 'topic' == $r['post_type'] ) {
+
             // Theme and plugin views rely on taxonomy queries.
             if ( isset( $r['tax_query'] ) ) {
+
+                // Only look at the last year of topics for the active view.
+                if ( bbp_is_single_view() && bbp_get_view_id() == 'active' ) {
+                    add_filter( 'posts_where', array( $this, 'posts_in_last_year' ) );
+                }
                 return $r;
             }
@@ -184 +190 @@
 
         $bound_id = $this->get_bound_id( '6 MONTH' );
+        $w .= $wpdb->prepare( " AND ( $wpdb->posts.ID >= %d )", $bound_id );
+        return $w;
+    }
+
+    public function posts_in_last_year( $w ) {
+        global $wpdb;
+
+        $bound_id = $this->get_bound_id( '1 YEAR' );
         $w .= $wpdb->prepare( " AND ( $wpdb->posts.ID >= %d )", $bound_id );
         return $w;