Changeset 4242

Timestamp:

10/14/2016 09:29:29 PM (8 years ago)

Author:

coffee2code

Message:

developer.wordpress.org: Add search form to 404 pages.

Props keesiemeijer.
Fixes #2089.

Location:

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer

Files:

• inc/template-tags.php (modified) (1 diff)
• scss/main.scss (modified) (1 diff)
• searchform.php (modified) (3 diffs)
• stylesheets/main.css (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/template-tags.php

@@ -1323 +1323 @@
         $taxonomies = array( 'wp-parser-since', 'wp-parser-package', 'wp-parser-source-file' );
 
-        return ! is_search() && ( is_singular( $post_types ) || is_post_type_archive( $post_types ) || is_tax( $taxonomies ) || get_query_var( 'is_handbook' ) );
+        return ! ( is_search() || is_404() ) && ( is_singular( $post_types ) || is_post_type_archive( $post_types ) || is_tax( $taxonomies ) || get_query_var( 'is_handbook' ) );
     }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/main.scss

@@ -524 +524 @@
     }
 
+    section.error-404 {
+        overflow: visible;
+    }
     .home-landing .section {
         padding: 30px 0%;

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/searchform.php

@@ -6 +6 @@
  */
 ?>
-<div class="search-section section clear <?php if ( ! ( is_page( 'reference' ) || is_search() ) ) { echo 'hide-if-js'; } ?>">
+<div class="search-section section clear <?php if ( ! ( is_page( 'reference' ) || is_search() || is_404() ) ) { echo 'hide-if-js'; } ?>">
 
 <?php if ( is_search() ) { ?>
@@ -38 +38 @@
         $search_url  = get_query_var( 'current_handbook_home_url' );
         $search_url  = $search_url ? $search_url : home_url( '/' );
-        $form_class  = $is_handbook ? ' searchform-handbook' : '';
+        $filters     = ! ( $is_handbook || is_404() );
+        $form_class  = ( $filters ) ? ' searchform-filtered' : '';
+        if ( $is_handbook ) {
+            $form_class .= ' searchform-handbook';
+        }
     ?>
 
@@ -50 +54 @@
         </div>
 
-    <?php if ( ! $is_handbook ) : ?>
+    <?php if ( $filters ) : ?>
 
         <div class="search-post-type">

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/main.css

@@ -865 +865 @@
 }
 
+.devhub-wrap section.error-404 {
+  overflow: visible;
+}
+
 .devhub-wrap .home-landing .section {
   padding: 30px 0%;