Changeset 4252

Timestamp:

10/18/2016 12:20:17 AM (10 years ago)

Author:

iandunn

Message:

WordCamp Logger: Add a few common password field keys to the blacklist.

Location:

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins

Files:

• 0-logger.php (modified) (2 diffs)
• jetpack-tweaks/new-sites.php (modified) (4 diffs)
• wp-cli-commands/miscellaneous.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/0-logger.php

@@ -49 +49 @@
  */
 function redact_keys( & $data ) {
-    $redacted_keys = array( 'Authorization' );
+    $redacted_keys = array( 'Authorization', 'password', 'user_pass' );
     $redacted_keys = array_map( 'strtolower', $redacted_keys ); // to avoid human error
 
@@ -75 +75 @@
  *
  * Based on https://stackoverflow.com/a/22508709/450127
- *
- * @todo It might be just as good to use getmypid(), but need to research/test first
  *
  * @return string

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/jetpack-tweaks/new-sites.php

@@ -21 +21 @@
 /**
  * Never automatically connect new sites to WordPress.com.
- * We offload this part to wp-cron.php because of https.
+ *
+ * Sites don't have SSL certificates when they're first created, so any attempt to connect to WordPress.com would
+ * fail. Instead, connecting is attempted after the SSL has been installed. See wcorg_connect_new_site().
  *
  * @param array $new_value
@@ -35 +37 @@
 
 /**
- * Schedule an attempt to connect this site to Jetpack.
+ * Schedule an attempt to connect Jetpack to WordPress.com
  *
  * @param int $blog_id The blog id.
@@ -41 +43 @@
 function schedule_connect_new_site( $blog_id ) {
     wp_schedule_single_event(
-        time() + 12 * HOUR_IN_SECONDS + 600,
+        time() + 12 * HOUR_IN_SECONDS + 600, // After the the SSL certificate has been installed
         'wcorg_connect_new_site',
         array( $blog_id, get_current_user_id() )
@@ -48 +50 @@
 
 /**
- * Connect the new site to Jetpack. Runs during wp-cron.php.
+ * Connect Jetpack to WordPress.com
+ *
+ * Runs during wp-cron.php.
  *
  * @param int $blog_id The blog_id to connect.

sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wp-cli-commands/miscellaneous.php

@@ -111 +111 @@
      *
      * wp wc-misc format-log /var/log/php-errors.log
-     * wp wc-misc format-log "$(grep 'foo' /var/log/php-errors.log --C 10)" |less -S
+     * wp wc-misc format-log "$(grep 'foo' /var/log/php-errors.log -C 10)" |less -S
      * wp wc-misc format-log "$(grep 'bar' /var/log/php-errors.log)" --foreign=ignore
      *