Changeset 4263

Timestamp:

10/19/2016 06:23:13 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Add no-js handling for JS-only sections and add the start of the admin sidebars.

See #2111

Location:

sites/trunk/wordpress.org/public_html/wp-content

Files:

• plugins/plugin-directory/class-plugin-directory.php (modified) (1 diff)
• plugins/plugin-directory/class-template.php (modified) (1 diff)
• plugins/plugin-directory/widgets/class-committers.php (added)
• plugins/plugin-directory/widgets/class-contributors.php (added)
• plugins/plugin-directory/widgets/class-plugin-review.php (added)
• themes/pub/wporg-plugins/client/components/plugin/sections/developers/index.jsx (modified) (1 diff)
• themes/pub/wporg-plugins/client/components/plugin/sections/faq/style.scss (modified) (1 diff)
• themes/pub/wporg-plugins/client/components/plugin/sections/style.scss (modified) (2 diffs)
• themes/pub/wporg-plugins/css/style-rtl.css (modified) (3 diffs)
• themes/pub/wporg-plugins/css/style.css (modified) (3 diffs)
• themes/pub/wporg-plugins/functions.php (modified) (1 diff)
• themes/pub/wporg-plugins/template-parts/plugin-sidebar-admin.php (added)
• themes/pub/wporg-plugins/template-parts/plugin-sidebar.php (added)
• themes/pub/wporg-plugins/template-parts/plugin-single.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -340 +340 @@
      */
     public function register_widgets() {
-        register_widget( __NAMESPACE__ . '\Widgets\Donate'  );
-        register_widget( __NAMESPACE__ . '\Widgets\Meta'    );
-        register_widget( __NAMESPACE__ . '\Widgets\Ratings' );
-        register_widget( __NAMESPACE__ . '\Widgets\Support' );
+        register_widget( __NAMESPACE__ . '\Widgets\Donate'        );
+        register_widget( __NAMESPACE__ . '\Widgets\Meta'          );
+        register_widget( __NAMESPACE__ . '\Widgets\Ratings'       );
+        register_widget( __NAMESPACE__ . '\Widgets\Support'       );
+        register_widget( __NAMESPACE__ . '\Widgets\Committers'    );
+        register_widget( __NAMESPACE__ . '\Widgets\Contributors'  );
+        register_widget( __NAMESPACE__ . '\Widgets\Plugin_Review' );
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php

@@ -176 +176 @@
 
                 case 'developers':
-                    $title = _x( 'Contributors & Developers', 'plugin tab title', 'wporg-plugins' );
+                    $title = _x( 'Authors', 'plugin tab title', 'wporg-plugins' );
                     $url   = trailingslashit( $permalink ) . '/' . $section_slug . '/';
                     break;

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client/components/plugin/sections/developers/index.jsx

@@ -10 +10 @@
             <div>
                 <div id="developers" className="read-more" aria-expanded="false">
-                    <h2>Contributors & Developers</h2>
+                    <h2>Authors</h2>
                     <DeveloperList contributors={ this.props.contributors } />
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client/components/plugin/sections/faq/style.scss

@@ -50 +50 @@
     }
 }
+
+.no-js .plugin-faqs dd {
+    display: block;
+}

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/client/components/plugin/sections/style.scss

@@ -52 +52 @@
 }
 
+.no-js .read-more {
+    overflow: auto;
+    max-height: none;
+}
+
 .section-toggle {
     color: $color__link;
@@ -70 +75 @@
     }
 }
+
+.no-js .section-toggle {
+    display: none;
+}

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/css/style-rtl.css

@@ -2199 +2199 @@
 }
 
+.no-js .plugin-faqs dd {
+    display: block;
+}
+
 .plugin-reviews {
   list-style-type: none;
@@ -2470 +2474 @@
 }
 
+.no-js .read-more,
 .read-more#reviews {
   max-height: none;
@@ -2538 +2543 @@
 .toggled + .section-toggle:after {
   content: "\f343";
+}
+
+.no-js .section-toggle {
+    display: none;
 }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/css/style.css

@@ -2199 +2199 @@
 }
 
+.no-js .plugin-faqs dd {
+    display: block;
+}
+
 .plugin-reviews {
   list-style-type: none;
@@ -2470 +2474 @@
 }
 
+.no-js .read-more,
 .read-more#reviews {
   max-height: none;
@@ -2538 +2543 @@
 .toggled + .section-toggle:after {
   content: "\f343";
+}
+
+.no-js .section-toggle {
+    display: none;
 }
 

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php

@@ -143 +143 @@
 
 
+function custom_body_class( $classes ) {
+    $classes[] = 'no-js';
+    return $classes;
+}
+add_filter( 'body_class', __NAMESPACE__ . '\custom_body_class' );
+
 /**
  * Adds hreflang link attributes to plugin pages.

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

@@ -15 +15 @@
 
 $content = Plugin_Directory::instance()->split_post_content_into_pages( get_the_content() );
-
-$widget_args = array(
-    'before_title' => '<h4 class="widget-title">',
-    'after_title'  => '</h4>',
-);
 
 ?><article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
@@ -144 +139 @@
     <div class="entry-meta">
         <?php
-        the_widget( 'WordPressdotorg\Plugin_Directory\Widgets\Meta',    array(), $widget_args );
-        the_widget( 'WordPressdotorg\Plugin_Directory\Widgets\Ratings', array(), $widget_args );
-        the_widget( 'WordPressdotorg\Plugin_Directory\Widgets\Support', array(), $widget_args );
-        the_widget( 'WordPressdotorg\Plugin_Directory\Widgets\Donate',  array(), $widget_args );
+        get_template_part( 'template-parts/plugin-sidebar', ( get_query_var( 'plugin_admin' ) ? 'admin' : '' ) );
         ?>
     </div><!-- .entry-meta -->