Changeset 4275

Timestamp:

10/20/2016 12:34:46 AM (7 years ago)

Author:

iandunn

Message:

WordCamp Post Type: Ensure maybe_create_new_site() only runs once

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-new-site.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-new-site.php

@@ -116 +116 @@
      */
     public function maybe_create_new_site( $wordcamp_id ) {
+        /*
+         * If this were to be called again before it had finished -- e.g., when `WCORMailer::replace_placeholders()`
+         * calls `WordCamp_Admin::metabox_save()` -- then it would `wpmu_create_blog()` would return a `blog_taken`
+         * `WP_Error` and `configure_site()` would never be called.
+         *
+         * @todo - If no other problems crop up with new site creation by 2016-12-01, then all of the logging
+         * that was added in r4254 can be removed, to make the code less cluttered and more readable.
+         */
+        if ( 1 !== did_action( 'wcpt_metabox_save_done' ) ) {
+            Logger\log( 'return_redundant_call' );
+            return;
+        }
+
         if ( ! current_user_can( 'manage_sites' ) ) {
             $current_user_id = get_current_user_id();