Changeset 4285 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php

Timestamp:

10/21/2016 09:12:32 PM (8 years ago)

Author:

iandunn

Message:

WordCamp Site Cloner: Lower sites query limit to 250 to avoid transient bug

See #1112

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.php

@@ -184 +184 @@
  * This is called via WP Cron.
  *
- * @todo - Reintroduce batching from `1112.3.diff` to get more than 500 sites
+ * @todo - Reintroduce batching from `1112.3.diff` to get more than 500 sites. Will need to fix transient bug
+ * mentioned in `get_wordcamp_sites()` first.
  */
 function prime_wordcamp_sites() {
@@ -217 +218 @@
 
     $wordcamp_query = new \WP_Query( array(
+        /*
+         * todo - There's a bug where a `posts_per_page` value greater than ~250-300 will result in
+         * `set_site_transient()` calling `add_site_option()` rather than `update_site_option()`,
+         * and then `get_site_transient()` fails, so `sites_endpoint()` returns an empty array.
+         */
         'post_type'      => WCPT_POST_TYPE_ID,
         'post_status'    => \WordCamp_Loader::get_public_post_statuses(),
-        'posts_per_page' => 500,
+        'posts_per_page' => 250,
         'meta_key'       => 'Start Date (YYYY-mm-dd)',
         'orderby'        => 'meta_value_num',