Changeset 4383

Timestamp:

11/21/2016 01:38:13 AM (10 years ago)

Author:

dd32

Message:

Plugin Directory: Reviewer admin UX tweaks

• Rename the menu from 'My Plugins' to 'Repo Plugins' to match theme directory
• Extend the 'slug' and 'author' inputs to be longer, accomodating longer slugs
• Add the 'submitter' column to the list view (post_author)
• Add the taxonomies columns to the list view (committer, contributors, tags

Plugin reviewers will most likely need to remove some of the columns through Screen Options to make the page usable, we can also remove some of the columns if they're not likely to be used.

See #2249.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• admin/class-customizations.php (modified) (2 diffs)
• admin/list-table/class-plugin-posts.php (modified) (2 diffs)
• class-plugin-directory.php (modified) (8 diffs)
• css/edit-form.css (modified) (1 diff)
• css/plugin-list.css (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php

@@ -108 +108 @@
                         switch ( $hook_suffix ) {
                                 case 'post.php':
-                                        wp_enqueue_style( 'plugin-admin-post-css', plugins_url( 'css/edit-form.css', Plugin_Directory\PLUGIN_FILE ), array( 'edit' ), 1 );
+                                        wp_enqueue_style( 'plugin-admin-post-css', plugins_url( 'css/edit-form.css', Plugin_Directory\PLUGIN_FILE ), array( 'edit' ), 2 );
                                         wp_enqueue_script( 'plugin-admin-post-js', plugins_url( 'js/edit-form.js', Plugin_Directory\PLUGIN_FILE ), array( 'wp-util', 'wp-lists' ), 1 );
                                         wp_localize_script( 'plugin-admin-post-js', 'pluginDirectory', array(
@@ -116 +116 @@
 
                                 case 'edit.php':
-                                        wp_enqueue_style( 'plugin-admin-edit-css', plugins_url( 'css/plugin-list.css', Plugin_Directory\PLUGIN_FILE ), array(), 1 );
+                                        wp_enqueue_style( 'plugin-admin-edit-css', plugins_url( 'css/plugin-list.css', Plugin_Directory\PLUGIN_FILE ), array(), 2 );
                                         break;
                         }

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php

@@ -105 +105 @@
                         /* translators: manage posts column name */
                         'title'     => _x( 'Title', 'column name', 'wporg-plugins' ),
+                        'author'    => __( 'Submitter', 'wporg-plugins' ),
                         'tested'    => __( 'Tested up to', 'wporg-plugins' ),
                         'rating'    => __( 'Rating', 'wporg-plugins' ),
@@ -112 +113 @@
                 );
 
-                if ( current_user_can( 'plugin_review' ) ) {
-                        $posts_columns['comments'] = '<span class="vers comment-grey-bubble" title="' . esc_attr__( 'Internal Notes', 'wporg-plugins' ) . '"><span class="screen-reader-text">' . __( 'Internal Notes', 'wporg-plugins' ) . '</span></span>';
-                }
-
+                $taxonomies = get_object_taxonomies( $post_type, 'objects' );
+                $taxonomies = wp_filter_object_list( $taxonomies, array( 'show_admin_column' => true ), 'and', 'name' );
+                $taxonomies = apply_filters( "manage_taxonomies_for_{$post_type}_columns", $taxonomies, $post_type );
+                $taxonomies = array_filter( $taxonomies, 'taxonomy_exists' );
+
+                foreach ( $taxonomies as $taxonomy ) {
+                        $column_key = 'taxonomy-' . $taxonomy;
+                        $posts_columns[ $column_key ] = get_taxonomy( $taxonomy )->labels->name;
+                }
+
+                $posts_columns['comments'] = '<span class="vers comment-grey-bubble" title="' . esc_attr__( 'Internal Notes', 'wporg-plugins' ) . '"><span class="screen-reader-text">' . __( 'Internal Notes', 'wporg-plugins' ) . '</span></span>';
                 $posts_columns['date'] = __( 'Date', 'wporg-plugins' );
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -88 +88 @@
                 register_post_type( 'plugin', array(
                         'labels'       => array(
-                                'name'               => __( 'Plugins',                   'wporg-plugins' ),
-                                'singular_name'      => __( 'Plugin',                    'wporg-plugins' ),
-                                'menu_name'          => __( 'My Plugins',                'wporg-plugins' ),
+                                'name'               => __( 'Repo Plugins',              'wporg-plugins' ),
+                                'singular_name'      => __( 'Repo Plugin',               'wporg-plugins' ),
+                                'menu_name'          => __( 'Repo Plugins',              'wporg-plugins' ),
                                 'add_new'            => __( 'Add New',                   'wporg-plugins' ),
                                 'add_new_item'       => __( 'Add New Plugin',            'wporg-plugins' ),
@@ -126 +126 @@
                         'rewrite'           => false,
                         'public'            => true,
-                        'show_ui'           => current_user_can( 'plugin_set_section' ),
-                        'show_admin_column' => current_user_can( 'plugin_set_section' ),
+                        'show_ui'           => true,
+                        'show_admin_column' => false,
                         'capabilities'      => array(
                                 'assign_terms' => 'plugin_set_section',
@@ -156 +156 @@
                         'public'            => true,
                         'show_ui'           => true,
-                        'show_admin_column' => true,
+                        'show_admin_column' => false,
                         'capabilities'      => array(
                                 'assign_terms' => 'plugin_set_category',
@@ -170 +170 @@
                         ),
                         'public'            => true,
-                        'show_ui'           => true,
+                        'show_ui'           => false,
                         'show_admin_column' => false,
                         'meta_box_cb'       => false,
@@ -186 +186 @@
                         ),
                         'public'            => true,
-                        'show_ui'           => true,
+                        'show_ui'           => false,
                         'show_admin_column' => false,
                         'meta_box_cb'       => false,
@@ -204 +204 @@
                         'public'            => true,
                         'show_ui'           => true,
-                        'show_admin_column' => false,
+                        'show_admin_column' => true,
                         'capabilities'      => array(
                                 'assign_terms' => 'do_not_allow',
@@ -220 +220 @@
                         'public'            => true,
                         'show_ui'           => true,
-                        'show_admin_column' => false,
+                        'show_admin_column' => true,
                         'capabilities'      => array(
                                 'assign_terms' => 'do_not_allow',
@@ -246 +246 @@
                         'public'            => true,
                         'show_ui'           => true,
-                        'show_admin_column' => false,
+                        'show_admin_column' => true,
                         'meta_box_cb'       => false,
                         'capabilities'      => array(

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/css/edit-form.css

@@ -34 +34 @@
 }
 
+input#post_name,
+input#post_author_username {
+        width: 350px;
+}
+
 .button-link:not(.handlediv) {
         color: #0073aa;

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/css/plugin-list.css

@@ -1 @@
-.fixed .column-tested,
-.fixed .column-rating,
-.fixed .column-installs,
-.fixed .column-downloads,
-.fixed .column-support {
-        width: 12%;
+.fixed .column-rating {
+        width: 100px;
 }