Changeset 4396

Timestamp:

11/21/2016 07:17:01 PM (10 years ago)

Author:

iandunn

Message:

WordCamp Budgets Dashboard: Remove non-existant variable from log entry.

$attendee doesn't exist inside this function after the refactoring in r4364.

Location:

sites/trunk/wordcamp.org/public_html/wp-content/plugins

Files:

• camptix-badge-generator/includes/html-badges.php (modified) (1 diff)
• camptix-badge-generator/includes/indesign-badges.php (modified) (2 diffs)
• wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (1 diff)
• wordcamp-payments-network/includes/wordcamp-budgets-dashboard.php (modified) (1 diff)
• wordcamp-qbo-client/wordcamp-qbo-client.php (modified) (1 diff)
• wordcamp-qbo/wordcamp-qbo.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-badge-generator/includes/html-badges.php

@@ -203 +203 @@
 /**
  * Render the template for HTML badges
+ *
+ * @todo Need some way of detecting failed HTTP requests for Gravatars and retrying them, like InDesign badges does
  */
 function render_badges_template() {

sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-badge-generator/includes/indesign-badges.php

@@ -105 +105 @@
  *                      image was successfully retrieved.
  *
- * @throws \Exception when the HTTP failed even after multiple attempts
+ * @todo If have any problems with downloads failing permenantly, can try doing `str_replace()` on `$request_url`
+ *       in order to change the `size` parameter to `512`.
+ *
+ * @todo Update this to use wcorg_redundant_remote_get() instead, for DRYness
+ *
+ * @throws \Exception when the HTTP request fails
  */
 function download_single_gravatar( $request_url ) {
@@ -131 +136 @@
 
                 if ( $attempt_count < 3 ) {
-                        Logger\log( 'request_failed_temporarily', compact( 'attendee', 'request_url', 'response', 'attempt_count', 'retry_after' ) );
+                        Logger\log( 'request_failed_temporarily', compact( 'request_url', 'response', 'attempt_count', 'retry_after' ) );
                         sleep( $retry_after );
                 } else {
-                        Logger\log( 'request_failed_permenantly', compact( 'attendee', 'request_url', 'response' ) );
+                        Logger\log( 'request_failed_permenantly', compact( 'request_url', 'response' ) );
                         throw new \Exception( __( "Couldn't download all Gravatars.", 'wordcamporg' ) );
                 }

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -257 +257 @@
                 $request_url      = add_query_arg( 'address', urlencode( $address ), 'https://maps.googleapis.com/maps/api/geocode/json' );
                 $geocode_response = json_decode( wp_remote_retrieve_body( wp_remote_get( $request_url ) ) );
+                // todo use wcorg_redundant_remote_get
 
                 if ( ! empty( $geocode_response->results[0]->geometry->location->lat ) ) {

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments-network/includes/wordcamp-budgets-dashboard.php

@@ -590 +590 @@
                 $url = add_query_arg( 'q',   rawurlencode( $wpdb->prepare( 'select * from yahoo.finance.xchange where pair = %s', $from . $to ) ), $url );
 
+                // todo use wcorg_redundant_remote_get
                 $request = wp_remote_get( esc_url_raw( $url ) );
                 $body = json_decode( wp_remote_retrieve_body( $request ), true );

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo-client/wordcamp-qbo-client.php

@@ -3 +3 @@
  * Plugin Name: WordCamp.org QBO Client
  */
+
+// todo use wcorg_redundant_remote_get for all the calls in this file
 
 use WordCamp\Logger;

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-qbo/wordcamp-qbo.php

@@ -3 +3 @@
  * Plugin Name: WordCamp.org QBO Integration
  */
+
+// todo use wcorg_redundant_remote_get for all the calls in this file
 
 use WordCamp\Logger;