Changeset 4396 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-badge-generator/includes/indesign-badges.php

Timestamp:

11/21/2016 07:17:01 PM (8 years ago)

Author:

iandunn

Message:

WordCamp Budgets Dashboard: Remove non-existant variable from log entry.

$attendee doesn't exist inside this function after the refactoring in r4364.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-badge-generator/includes/indesign-badges.php (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/camptix-badge-generator/includes/indesign-badges.php

@@ -105 +105 @@
  *                      image was successfully retrieved.
  *
- * @throws \Exception when the HTTP failed even after multiple attempts
+ * @todo If have any problems with downloads failing permenantly, can try doing `str_replace()` on `$request_url`
+ *       in order to change the `size` parameter to `512`.
+ *
+ * @todo Update this to use wcorg_redundant_remote_get() instead, for DRYness
+ *
+ * @throws \Exception when the HTTP request fails
  */
 function download_single_gravatar( $request_url ) {
@@ -131 +136 @@
 
         if ( $attempt_count < 3 ) {
-            Logger\log( 'request_failed_temporarily', compact( 'attendee', 'request_url', 'response', 'attempt_count', 'retry_after' ) );
+            Logger\log( 'request_failed_temporarily', compact( 'request_url', 'response', 'attempt_count', 'retry_after' ) );
             sleep( $retry_after );
         } else {
-            Logger\log( 'request_failed_permenantly', compact( 'attendee', 'request_url', 'response' ) );
+            Logger\log( 'request_failed_permenantly', compact( 'request_url', 'response' ) );
             throw new \Exception( __( "Couldn't download all Gravatars.", 'wordcamporg' ) );
         }