Changeset 4410 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

Timestamp:

11/24/2016 01:38:06 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Clean up the section templates, bring some custom functionality into their respective shortcodes and shifting the read-more logic from CSS/JS to PHP/HTML.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/template-parts/plugin-single.php

@@ -12 +12 @@
 use WordPressdotorg\Plugin_Directory\Template;
 use WordPressdotorg\Plugin_Directory\Tools;
-global $section, $section_slug, $section_content;
+global $section, $section_slug, $section_content, $section_read_more;
 
 $content = Plugin_Directory::instance()->split_post_content_into_pages( get_the_content() );
@@ -114 +114 @@
         <?php
         if ( get_query_var( 'plugin_admin' ) ) :
-            get_template_part( 'template-parts/section', 'admin' );
+            get_template_part( 'template-parts/section-admin' );
         else:
             $plugin_sections = Template::get_plugin_sections();
 
             foreach ( array( 'description', 'screenshots', 'faq', 'reviews', 'changelog', 'developers' ) as $section_slug ) :
-                if ( ! array_key_exists( $section_slug, $content ) || in_array( $section_slug, array( 'installation', 'other_notes' ) ) ) :
+                if ( ! isset( $content[ $section_slug ] ) ) {
                     continue;
-                endif;
+                }
 
                 $section_content = trim( apply_filters( 'the_content', $content[ $section_slug ], $section_slug ) );
-                if ( empty( $section_content ) ) :
+                if ( empty( $section_content ) ) {
                     continue;
-                endif;
+                }
 
                 $section = wp_list_filter( $plugin_sections, array( 'slug' => $section_slug ) );
                 $section = array_pop( $section );
 
-                get_template_part( 'template-parts/section', $section_slug );
+                $section_no_read_mores = array( 'screenshots', 'reviews' );
+                // If the FAQ section is the newer `<dl>` form, no need to do read-more for it.
+                if ( false !== stripos( $section_content, '<dl>' ) ) {
+                    $section_no_read_mores[] = 'faq';
+                }
+                
+                $section_read_more = ! in_array( $section_slug, $section_no_read_mores );
+
+                get_template_part( 'template-parts/section' );
             endforeach;
         endif; // plugin_admin