Changeset 4423

Timestamp:

11/26/2016 03:47:38 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: Update the tested postmeta field when new versions of WordPress are released.
This removes the need for having a postmeta display filter.

Location:

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory

Files:

• class-plugin-directory.php (modified) (2 diffs)
• cli/class-import.php (modified) (1 diff)
• jobs/class-meta-sync.php (modified) (3 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php

@@ -50 +50 @@
         add_filter( 'oembed_providers', array( $this, 'oembed_whitelist' ) );
 
-        // Shim in postmeta support for data which doesn't yet live in postmeta.
-        add_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ), 10, 3 );
-
+        // Capability mapping
         add_filter( 'map_meta_cap', array( __NAMESPACE__ . '\Capabilities', 'map_meta_cap' ), 10, 4 );
 
@@ -951 +949 @@
             return false;
         } );
-    }
-
-    /**
-     * Shim in some postmeta values which get retrieved from other locations temporarily.
-     *
-     * @param null|array|string $value     The value get_metadata() should return - a single metadata value,
-     *                                     or an array of values.
-     * @param int               $object_id Object ID.
-     * @param string            $meta_key  Meta key.
-     * @return array
-     */
-    public function filter_shim_postmeta( $value, $object_id, $meta_key ) {
-        switch ( $meta_key ) {
-            case 'tested':
-                // For the tested field, we bump up the minor release to the latest compatible minor release.
-                if ( function_exists( 'wporg_get_version_equivalents' ) ) {
-
-                    // As we're on a pre-filter, we'll have to detach, fetch and reattach..
-                    remove_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ) );
-                    $value = get_metadata( 'post', $object_id, $meta_key );
-                    add_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ), 10, 3 );
-
-                    foreach ( wporg_get_version_equivalents() as $latest_compatible_version => $compatible_with ) {
-                        if ( in_array( (string)$value[0], $compatible_with, true ) ) {
-                            $value[0] = $latest_compatible_version;
-                            break;
-                        }
-                    }
-                }
-                break;
-
-            case false:
-
-                // In the event $meta_key is false, the caller wants all meta fields, so we'll append our custom ones here too.
-                remove_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ) );
-
-                // Fetch the existing ones from the database
-                $value = get_metadata( 'post', $object_id, $meta_key );
-
-                // Re-attach ourselves for next time!
-                add_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ), 10, 3 );
-
-                $custom_meta_fields = array( 'downloads', 'rating', 'ratings', 'tested' );
-                $custom_meta_fields = apply_filters( 'wporg_plugins_custom_meta_fields', $custom_meta_fields, $object_id );
-
-                foreach ( $custom_meta_fields as $key ) {
-
-                    // When WordPress calls `get_post_meta( $post_id, false )` it expects an array of maybe_serialize()'d data.
-                    $shimed_data = $this->filter_shim_postmeta( false, $object_id, $key );
-                    if ( $shimed_data ) {
-                        $value[ $key ][0] = (string) maybe_serialize( $shimed_data[0] );
-                    }
-                }
-                break;
-
-        }
-
-        return $value;
     }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php

@@ -147 +147 @@
         }
 
+        // Update the tested-up-to value
+        $tested = $readme->tested;
+        if ( function_exists( 'wporg_get_version_equivalents' ) ) {
+            foreach ( wporg_get_version_equivalents() as $latest_compatible_version => $compatible_with ) {
+                if ( in_array( $readme->tested, $compatible_with, true ) ) {
+                    $tested = $latest_compatible_version;
+                    break;
+                }
+            }
+        }
+
+        // Update all readme meta
         foreach ( $this->readme_fields as $readme_field ) {
-            // Don't change the tested version if a newer version was specified through wp-admin
-            if ( 'tested' == $readme_field && version_compare( get_post_meta( $plugin->ID, 'tested', true ), $readme->$readme_field, '>' ) ) {
-                continue;
-            }
-
-            update_post_meta( $plugin->ID, $readme_field, wp_slash( $readme->$readme_field ) );
+            $value = ( 'tested' == $readme_field ) ? $tested : $readme->field;
+            update_post_meta( $plugin->ID, $readme_field, wp_slash( $value ) );
         }
 

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php

@@ -24 +24 @@
         $this->sync_downloads();
         $this->sync_ratings();
+        $this->update_tested_up_to();
     }
 
@@ -39 +40 @@
             FROM `{$wpdb->posts}` p
                 JOIN `{$bbpress_topic_slug_table}` t ON p.post_name = t.topic_slug
-                LEFT JOIN `{$download_count_table}` c on t.topic_id = c.topic_id
+                JOIN `{$download_count_table}` c on t.topic_id = c.topic_id
                 LEFT JOIN `{$wpdb->postmeta}` pm ON p.id = pm.post_id AND pm.meta_key = 'downloads'
 
@@ -96 +97 @@
         update_option( 'plugin_last_review_sync', $current_review_time, 'no' );
     }
+
+    /**
+     * After WordPress is released, update the 'tested' meta keys to the latest version as
+     * specified by `wporg_get_version_equivalents()`.
+     */
+    function update_tested_up_to() {
+        global $wpdb;
+        if ( ! function_exists( 'wporg_get_version_equivalents' ) ) {
+            return;
+        }
+
+        $equivs = wporg_get_version_equivalents();
+        $equivs_key = md5( serialize( $equivs ) );
+        if ( $equivs_key === get_option( 'plugin_last_tested_sync' ) ) {
+            return;
+        }
+
+        $latest_equiv = array();
+        foreach ( $equivs as $latest_compatible_version => $compatible_with ) {
+            foreach ( $compatible_with as $version ) {
+                $latest_equiv[ $version ] = $latest_compatible_version;
+            }
+        }
+
+        $tested_meta_value_esc_sql = '"' . implode( '", "', array_map( 'esc_sql', array_keys( $latest_equiv ) ) ) . '"';
+        $tested_values = $wpdb->get_results( "SELECT post_id, meta_value FROM {$wpdb->postmeta} WHERE meta_key = 'tested' AND meta_value IN( {$tested_meta_value_esc_sql} )" );
+
+        foreach ( $tested_values as $row ) {
+            update_post_meta(
+                $row->post_id,
+                'tested',
+                $latest_equiv[ $row->meta_value ]
+            );
+        }
+
+        update_option( 'plugin_last_tested_sync', $equivs_key );
+    }
 }