Changeset 4505 for sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php

Timestamp:

12/08/2016 01:58:37 PM (8 years ago)

Author:

obenland

Message:

Plugin Directory: Use get_post() for template functions.

Template functions should fall back to the global post object.
Also fixes a bug where assets weren't loaded correctly while in the loop.

Props joostdevalk for initial patch.
Fixes #2303.

File:

• sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/functions.php

@@ -164 +164 @@
     }
 
-    $post_id = get_the_ID();
-    $banner  = Template::get_plugin_banner( $post_id );
+    $banner  = Template::get_plugin_banner();
     $banner['banner_2x'] = $banner['banner_2x'] ? $banner['banner'] : false;
-    $icon = Template::get_plugin_icon( $post_id );
-
-    printf( '<meta property="og:title" content="%s" />' . "\n", the_title_attribute( array( 'echo' => false, 'post' => $post_id ) ) );
-    printf( '<meta property="og:description" content="%s" />' . "\n", esc_attr( strip_tags( get_the_excerpt( $post_id ) ) ) );
+    $icon = Template::get_plugin_icon();
+
+    printf( '<meta property="og:title" content="%s" />' . "\n", the_title_attribute( array( 'echo' => false ) ) );
+    printf( '<meta property="og:description" content="%s" />' . "\n", esc_attr( strip_tags( get_the_excerpt() ) ) );
     printf( '<meta property="og:site_name" content="WordPress.org" />' . "\n" );
     printf( '<meta property="og:type" content="website" />' . "\n" );
-    printf( '<meta property="og:url" content="%s" />' . "\n", esc_url( get_permalink( $post_id ) ) );
+    printf( '<meta property="og:url" content="%s" />' . "\n", esc_url( get_permalink() ) );
     printf( '<meta name="twitter:card" content="summary_large_image">' . "\n" );
     printf( '<meta name="twitter:site" content="@WordPress">' . "\n" );
 
     if ( $banner['banner_2x'] ) {
-        printf( '<meta name="twitter:image" content="%s" />' . "\n", $banner['banner_2x'] );
+        printf( '<meta name="twitter:image" content="%s" />' . "\n", esc_url( $banner['banner_2x'] ) );
     }
     if ( isset( $banner['banner'] ) ) {
-        printf( '<meta property="og:image" content="%s" />' . "\n", $banner['banner'] );
+        printf( '<meta property="og:image" content="%s" />' . "\n", esc_url( $banner['banner'] ) );
     }
     if ( ! $icon['generated'] && ( $icon['icon_2x'] || $icon['icon'] ) ) {
-        printf( '<meta name="thumbnail" content="%s" />', $icon['icon_2x'] ?: $icon['icon'] );
+        printf( '<meta name="thumbnail" content="%s" />' . "\n", esc_url( $icon['icon_2x'] ?: $icon['icon'] ) );
     }
 }