Changeset 4559 for sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin.php

Timestamp:

12/19/2016 07:00:06 AM (10 years ago)

Author:

dd32

Message:

Plugin Directory: Allow us to return the FAQ section with <h4> instead of <dl> for existing WordPress versions.
Also fixes the hot_tags endpoint to work correctly.

See #2112.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin.php

@@ -112 +112 @@
                 }
                 $result['sections']['reviews'] = $this->get_plugin_reviews_markup( $post->post_name );
+                if ( !empty( $result['sections']['faq'] ) ) {
+                        $result['sections']['enhanced_faq'] = $result['sections']['faq'];
+                        $result['sections']['faq'] = $this->get_simplified_faq_markup( $result['sections']['enhanced_faq'] );
+                } 
+                
                 $result['description'] = $result['sections']['description'];
 
@@ -271 +276 @@
         }
 
+        /**
+         * Return a 'simplified' markup for the FAQ screen.
+         * WordPress only supports a whitelisted selection of tags, `<dl>` is not one of them.
+         *
+         * @see https://core.trac.wordpress.org/browser/tags/4.7/src/wp-admin/includes/plugin-install.php#L478
+         * @param string $markup The existing Markup.
+         * @return string Them markup with `<dt>` replaced with `<h4>` and `<dd>` with `<p>`.
+         */
+        protected function get_simplified_faq_markup( $markup ) {
+                $markup = str_replace(
+                        array( '<dl>', '</dl>', '<dt>', '</dt>', '<dd>', '</dd>' ),
+                        array( '',      '',     '<h4>', '</h4>', '<p>',  '</p>'  ),
+                        $markup
+                );
+
+                return $markup;
+        }
+
 }