Changeset 4572

Timestamp:

12/23/2016 02:10:39 AM (8 years ago)

Author:

dd32

Message:

Plugin Directory: API: Return an empty array of tags for when the hot_tags api is unavailable.
The handling for the 'error' key was previously being matched by.. the error tag.. Even when an error is returned to the client though, WordPress includes no error-case handler here, so returning an empty array is safer.

See #2112

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api.php (modified) (2 diffs)

sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/standalone/class-plugins-info-api.php

@@ -204 +204 @@
 
             if ( 200 != $response->status ) {
-                $response = array( 'error' => 'Temporarily Unavailable' );
+                $response = array(); // WordPress includes no handling for this API being unavailable, so just return nothing.
                 wp_cache_set( $cache_key, $response, self::CACHE_GROUP, 30 ); // Short expiry for when we've got issues
             } else {
@@ -210 +210 @@
                 wp_cache_set( $cache_key, $response, self::CACHE_GROUP, self::CACHE_EXPIRY );
             }
-        }
-
-        if ( isset( $response['error'] ) ) {
-            $this->output( (object) $response );
-            return;
         }