Changeset 4577 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

Timestamp:

12/23/2016 05:27:38 PM (9 years ago)

Author:

iandunn

Message:

WordCamp Site Cloner: Refactor for compatibility with WP 4.7 and Jetpack 4.2.2

WordPress 4.7 added a Customizer feature that allows editing CSS. Jetpack 4.2.2 replaced the Custom CSS module with an entirely new one that is compatible with the Customizer feature, but broke backwards-compatibility with the Site Cloner and Remote CSS plugins.

This commit refactors the Site Cloner to restore compatibility with Jetpack, and add support for the new Core feature.

​https://make.wordpress.org/core/2016/10/11/feature-proposal-better-theme-customizations-via-custom-css-with-live-previews/
​https://make.wordpress.org/core/2016/11/26/extending-the-custom-css-editor/
​https://github.com/Automattic/jetpack/issues/5539
​https://github.com/Automattic/jetpack/pull/5804
​https://core.trac.wordpress.org/ticket/35395
​https://core.trac.wordpress.org/ticket/38672
​https://core.trac.wordpress.org/ticket/39270

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wcpt/wcpt-wordcamp/wordcamp-admin.php

@@ -721 +721 @@
 
         if ( $old_status == 'wcpt-pre-planning' && $new_status == 'wcpt-pre-planning' ) {
+            // todo - bug: this won't ever run b/c of the early return above.
+            // what commit made this mistake, and why?
+            // what things are tied to this that haven't been running?
             do_action( 'wcpt_added_to_planning_schedule', $post );
         } elseif ( $old_status == 'wcpt-needs-schedule' && $new_status == 'wcpt-scheduled' ) {