Changeset 4678

Timestamp:

01/14/2017 02:05:34 AM (9 years ago)

Author:

coreymckrill

Message:

WordCamp Site Cloner: Fix infinite scrolling of site search results

The script was binding to the scroll event on the wrong element, so the
bound method was never firing. This changes the bind to the element that
actually has a scroll bar. It's possible that this problem was caused
by markup changes in the Customizer.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.js (modified) (2 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/wordcamp-site-cloner.js

@@ -48 +48 @@
 
             // Container that will be scrolled within
-            this.$container = $( '#wcsc-cloner' ).parents( 'ul.accordion-section-content' );
+            this.$container = $( '#wcsc-cloner' ).parents( '.wp-full-overlay-sidebar-content' );
             // Bind scrolling within the container to check for infinite scroll
             this.$container.bind( 'scroll', _.throttle( this.scroller, 300 ) );
@@ -159 +159 @@
 
         paginate : function( pageIndex ) {
-            var collection = this;
+            var collection = this,
+                perPage    = 20;
 
             pageIndex  = pageIndex || 0;
 
-            collection = _( collection.rest( 20 * pageIndex ) );
-            collection = _( collection.first( 20 ) );
+            collection = _( collection.rest( perPage * pageIndex ) );
+            collection = _( collection.first( perPage ) );
 
             return collection;