Changeset 4726 for sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/includes/source-site-id-setting.php

Timestamp:

01/19/2017 12:45:23 AM (8 years ago)

Author:

iandunn

Message:

WordCamp Site Cloner: Set theme mods before saving to sanitize correct field

If the CSS is saved and sanitized before the theme mods are set, then Jetpack use the previous preprocessor value, which will often be incorrect. In many cases, this leads to sanitizing the preprocssed CSS instead of the vanilla CSS, which breaks it.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/includes/source-site-id-setting.php (modified) (1 diff)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-site-cloner/includes/source-site-id-setting.php

@@ -158 +158 @@
         restore_current_blog();
 
+        /*
+         * The vanilla CSS will be sanitized by Jetpack and our custom sanitization during `update_custom_css_data`.
+         * The theme mods need to be set _first_, so that the Jetpack knows whether or not a preprocessor should
+         * be used.
+         */
+        set_theme_mod( 'jetpack_custom_css', $source_site_theme_mods );
         wp_update_custom_css_post( $source_site_css );
-        set_theme_mod( 'jetpack_custom_css', $source_site_theme_mods );
     }
 }