Changeset 480

Timestamp:

03/28/2014 03:59:02 PM (11 years ago)

Author:

iandunn

Message:

WordCamp Calendar: Explicitly send a full CRLF.

RFC 2445 requires a full CRLF, but previously we were just sending
n. That may not have mattered at all in the real world, but I've gotten reproducable reports of Google Calendar failing to import any of the events from the feed. This didn't end up fixing the problem, but I'm committing it anyway since the work is already done and it brings the output in line with the RFC.

File:

• sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-api/classes/ics.php (modified) (3 diffs)

sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-api/classes/ics.php

@@ -3 +3 @@
 class WordCamp_API_ICS {
     public $ttl = 1; // seconds to live
+    const CLRF = "\r\n";
 
     function __construct() {
@@ -47 +48 @@
             define( 'WPCT_POST_TYPE_ID', 'wordcamp' );
 
-        $ical = 'BEGIN:VCALENDAR
-VERSION:2.0
-PRODID:-//hacksw/handcal//NONSGML v1.0//EN
-';
+        $ical = 'BEGIN:VCALENDAR' . self::CLRF;
+        $ical .= 'VERSION:2.0'  . self::CLRF;
+        $ical .= 'PRODID:-//hacksw/handcal//NONSGML v1.0//EN' . self::CLRF;
 
         $query = new WP_Query( array(
@@ -79 +79 @@
             $end = date( 'Ymd', $end );
 
-            $ical .= "BEGIN:VEVENT
-UID:$uid
-DTSTAMP;VALUE=DATE:$start
-DTSTART;VALUE=DATE:$start
-DTEND;VALUE=DATE:$end
-SUMMARY:$title
-END:VEVENT
-";
-
+            $ical .= "BEGIN:VEVENT" . self::CLRF;
+            $ical .= "UID:$uid" . self::CLRF;
+            $ical .= "DTSTAMP;VALUE=DATE:$start" . self::CLRF;
+            $ical .= "DTSTART;VALUE=DATE:$start" . self::CLRF;
+            $ical .= "DTEND;VALUE=DATE:$end" . self::CLRF;
+            $ical .= "SUMMARY:$title" . self::CLRF;
+            $ical .= "END:VEVENT" . self::CLRF;
         }