Changeset 4809

Timestamp:

01/27/2017 03:45:59 PM (10 years ago)

Author:

iandunn

Message:

Official WordPress Events: Return shortcode output to fix display bug

Shortcodes are supposed to return output rather than printing it. This bug wasn't obvious when make/Community was using the p2 theme because of its particular layout, but when the site switched to o2 the bug because obvious, because the output was not being displayed at all.

File:

• sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php (modified) (1 diff)

sites/trunk/wordpress.org/public_html/wp-content/plugins/official-wordpress-events/official-wordpress-events.php

@@ -50 +50 @@
          */
         public function render_events() {
+                $output = '';
                 $events = $this->group_events_by_date( $this->get_all_events() );
 
                 if ( $events ) {
+                        ob_start();
                         require_once( __DIR__ . '/template-events.php' );
-                }
+                        $output = ob_get_flush();
+                }
+
+                return $output;
         }